Page MenuHomePhabricator

git: implement some changelog methods
ClosedPublic

Authored by rom1dep on Sun, May 17, 1:41 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rom1dep created this revision.Sun, May 17, 1:41 PM

I assume this fixed ... something? Is there any test you could add to one of the test-git*.t tests that would demonstrate that?

hi @durin42 , yes indeed, that fixes tortoisehg's loading of a hgit repo (now the DAG is fully visible, selection of commits work, I have other patches there too to work around things for status),
I didn't think much of these changes because the added methods are rip-offs of the ones in /mercurial/revlog.py,
maybe there is an abstraction which could be used there so not to duplicate this code/these tests?

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.