Page MenuHomePhabricator

context: avoid computing status twice when comparing among revisions
Needs RevisionPublic

Authored by rom1dep on May 25 2020, 2:48 AM.

Details

Reviewers
marmoute
durin42
Group Reviewers
hg-reviewers

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

rom1dep created this revision.May 25 2020, 2:48 AM

No real justification for, only found it weird, and since we have to do that test anyway I didn't think it would make perfs worse,
Didn't run tests on it, though.

marmoute accepted this revision.May 26 2020, 9:45 AM
marmoute added a subscriber: marmoute.

This looks fine.

durin42 requested changes to this revision.May 26 2020, 12:37 PM
durin42 added a subscriber: durin42.

Breaks many tests for status code, sadly.

(Regrettably, I've already lost that output, and I need to go get lunch with family.)

This revision now requires changes to proceed.May 26 2020, 12:37 PM