Page MenuHomePhabricator

sshpeer: make client print (likely) server errors on stderr
ClosedPublic

Authored by valentin.gatienbaron on May 26 2020, 6:42 AM.

Details

Summary

so hg clone -q or hg pull -q don't print `abort: no suitable
response from remote hg!` with no indication of what went wrong.

There are other errors still silenced by -q (like failing to push due
to a server hook), but the current change covers a good fraction of
the problem (all errors setting up the ssh connection, no such remote
repository, no access to the repository).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute requested changes to this revision.May 26 2020, 9:58 AM
marmoute added a subscriber: marmoute.

This should be flagged as (BC) in the changeset summary.

The change itself seems fine.

This revision now requires changes to proceed.May 26 2020, 9:58 AM
This revision was not accepted when it landed; it landed in state Needs Revision.
This revision was automatically updated to reflect the committed changes.