This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8589

metadata: filter the `removed` set to only contains relevant data
ClosedPublic

Authored by marmoute on May 27 2020, 9:17 AM.

Details

Reviewers
durin42
pulkit
Group Reviewers
hg-reviewers
Commits
rHG25512a65cefd: metadata: filter the `removed` set to only contains relevant data
Summary

The files entry can be bogus and contains too many entries. This can badly
combines with the computation of removed inflating the set size. The can lead
to the changesets centric rename computation to process much more data than
needed, slowing it down (and increasing space taken by data storage).

In practice newer commits already that reduced set, this applies this "fix" to
older changeset.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.May 27 2020, 9:17 AM
durin42 accepted this revision.May 28 2020, 11:38 AM
This revision is now accepted and ready to land.May 28 2020, 11:38 AM
marmoute updated this revision to Diff 21547.Jun 2 2020, 6:48 AM
pulkit accepted this revision.Jun 9 2020, 5:45 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/metadata.py (3 lines)

Diff 21585

mercurial/metadata.py

def computechangesetfilesremoved(ctx): def computechangesetfilesremoved(ctx):
"""return the list of files removed in a changeset """return the list of files removed in a changeset
""" """
removed = [] removed = []
for f in ctx.files(): for f in ctx.files():
if f not in ctx: if f not in ctx:
removed.append(f) removed.append(f)
if removed:
rf = get_removal_filter(ctx)
removed = [r for r in removed if not rf(r)]
return removed return removed
def computechangesetcopies(ctx): def computechangesetcopies(ctx):
"""return the copies data for a changeset """return the copies data for a changeset
The copies data are returned as a pair of dictionnary (p1copies, p2copies). The copies data are returned as a pair of dictionnary (p1copies, p2copies).