Page MenuHomePhabricator

rust: remove support for `re2`
ClosedPublic

Authored by Alphare on May 29 2020, 6:34 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG9f96beb9bafe: rust: remove support for `re2`
Summary

With the performance issues with regex figured out and fixed in previous
patches and regex newly gaining support for empty alternations, there is no
reason to keep re2 around anymore. It's only *marginally* faster at creating
the regex which saves at most a couple of ms, but gets beaten by regex in
every other aspect.

This removes the Rust/C/C++ bridge (hooray!), the with-re2 feature, the
conditional code that goes with it, the documentation and relevant part of the
debug/module output.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.May 29 2020, 6:34 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.