( )⚙ D8606 context: fix creation of ProgrammingError to not use non-existent field

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8606

context: fix creation of ProgrammingError to not use non-existent field
ClosedPublic

Authored by martinvonz on Jun 4 2020, 12:53 AM.

Details

Reviewers
mjacob
pulkit
Group Reviewers
hg-reviewers
Commits
rHGb2e5ec0c596b: context: fix creation of ProgrammingError to not use non-existent field

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jun 4 2020, 12:53 AM
mjacob added a subscriber: mjacob.Jun 4 2020, 2:04 AM

Otherwise, LGTM.

mercurial/context.py
2325

same problem here

martinvonz retitled this revision from context: fix creation of a ProgrammingError to not use non-existent field to context: fix creation of ProgrammingError to not use non-existent field.Jun 4 2020, 11:03 AM
martinvonz updated this revision to Diff 21551.
martinvonz marked an inline comment as done.Jun 4 2020, 11:03 AM
mjacob accepted this revision.Jun 4 2020, 1:23 PM
pulkit accepted this revision.Jun 9 2020, 4:43 AM
This revision is now accepted and ready to land.Jun 9 2020, 4:43 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/context.py (4 lines)

Diff 21575

mercurial/context.py

return None return None
def flags(self, path): def flags(self, path):
if self.isdirty(path): if self.isdirty(path):
if self._cache[path][b'exists']: if self._cache[path][b'exists']:
return self._cache[path][b'flags'] return self._cache[path][b'flags']
else: else:
raise error.ProgrammingError( raise error.ProgrammingError(
b"No such file or directory: %s" % self._path b"No such file or directory: %s" % path
mjacobUnsubmitted
Done

same problem here

mjacob: same problem here
) )
else: else:
return self._wrappedctx[path].flags() return self._wrappedctx[path].flags()
def __contains__(self, key): def __contains__(self, key):
if key in self._cache: if key in self._cache:
return self._cache[key][b'exists'] return self._cache[key][b'exists']
return key in self.p1() return key in self.p1()
return self._existsinparent(path) return self._existsinparent(path)
def size(self, path): def size(self, path):
if self.isdirty(path): if self.isdirty(path):
if self._cache[path][b'exists']: if self._cache[path][b'exists']:
return len(self._cache[path][b'data']) return len(self._cache[path][b'data'])
else: else:
raise error.ProgrammingError( raise error.ProgrammingError(
b"No such file or directory: %s" % self._path b"No such file or directory: %s" % path
) )
return self._wrappedctx[path].size() return self._wrappedctx[path].size()
def tomemctx( def tomemctx(
self, self,
text, text,
branch=None, branch=None,
extra=None, extra=None,