Page MenuHomePhabricator

merge: move an inspection of the dirstate from record to calculate phase
ClosedPublic

Authored by martinvonz on Fri, Jun 5, 9:37 PM.

Details

Summary

The intent is clearly to have calculateupdates() figure out what
actions need to be taken and recordupdates() to make necessary
modifications to the dirstate. However, in the
ACTION_PATH_CONFLICT_RESOLVE case, there was one little inspection
of copy information done in recordupdates(). This patch moves that
to calculateupdates(). That will help with the next patch, which
makes merge.update() work better with overlayworkingctx (copies
should be recorded there too, even though we skip the
recordupdates() step).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.