( )⚙ D866 tests: disable lints on mercurial/thirdparty

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D866

tests: disable lints on mercurial/thirdparty
ClosedPublic

Authored by sid0 on Oct 1 2017, 6:35 AM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG41401f502c83: tests: disable lints on mercurial/thirdparty
Summary

In the next patch, this directory will be used to vendor in some third-party
code.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

sid0 created this revision.Oct 1 2017, 6:35 AM
durin42 accepted this revision.Oct 1 2017, 6:55 AM
This revision is now accepted and ready to land.Oct 1 2017, 6:55 AM
Closed by commit rHG41401f502c83: tests: disable lints on mercurial/thirdparty (authored by sid0). · Explain WhyOct 1 2017, 7:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2230

contrib/import-checker.py

'mercurial.node', 'mercurial.node',
# for cffi modules to re-export pure functions # for cffi modules to re-export pure functions
'mercurial.pure.base85', 'mercurial.pure.base85',
'mercurial.pure.bdiff', 'mercurial.pure.bdiff',
'mercurial.pure.diffhelpers', 'mercurial.pure.diffhelpers',
'mercurial.pure.mpatch', 'mercurial.pure.mpatch',
'mercurial.pure.osutil', 'mercurial.pure.osutil',
'mercurial.pure.parsers', 'mercurial.pure.parsers',
# third-party imports should be directly imported
'mercurial.thirdparty',
) )
# Whitelist of symbols that can be directly imported. # Whitelist of symbols that can be directly imported.
directsymbols = ( directsymbols = (
'demandimport', 'demandimport',
) )
# Modules that must be aliased because they are commonly confused with # Modules that must be aliased because they are commonly confused with

tests/test-check-code.t

#require test-repo #require test-repo
$ . "$TESTDIR/helpers-testrepo.sh" $ . "$TESTDIR/helpers-testrepo.sh"
$ check_code="$TESTDIR"/../contrib/check-code.py $ check_code="$TESTDIR"/../contrib/check-code.py
$ cd "$TESTDIR"/.. $ cd "$TESTDIR"/..
New errors are not allowed. Warnings are strongly discouraged. New errors are not allowed. Warnings are strongly discouraged.
(The writing "no-che?k-code" is for not skipping this file when checking.) (The writing "no-che?k-code" is for not skipping this file when checking.)
$ testrepohg locate -X contrib/python-zstandard \ $ testrepohg locate \
> -X hgext/fsmonitor/pywatchman | > -X contrib/python-zstandard \
> sed 's-\\-/-g' | "$check_code" --warnings --per-file=0 - || false > -X hgext/fsmonitor/pywatchman \
> -X mercurial/thirdparty \
> | sed 's-\\-/-g' | "$check_code" --warnings --per-file=0 - || false
Skipping i18n/polib.py it has no-che?k-code (glob) Skipping i18n/polib.py it has no-che?k-code (glob)
Skipping mercurial/httpclient/__init__.py it has no-che?k-code (glob) Skipping mercurial/httpclient/__init__.py it has no-che?k-code (glob)
Skipping mercurial/httpclient/_readers.py it has no-che?k-code (glob) Skipping mercurial/httpclient/_readers.py it has no-che?k-code (glob)
Skipping mercurial/selectors2.py it has no-che?k-code (glob) Skipping mercurial/selectors2.py it has no-che?k-code (glob)
Skipping mercurial/statprof.py it has no-che?k-code (glob) Skipping mercurial/statprof.py it has no-che?k-code (glob)
Skipping tests/badserverext.py it has no-che?k-code (glob) Skipping tests/badserverext.py it has no-che?k-code (glob)
@commands in debugcommands.py should be in alphabetical order. @commands in debugcommands.py should be in alphabetical order.

tests/test-check-module-imports.t

> -X setup.py \ > -X setup.py \
> -X contrib/debugshell.py \ > -X contrib/debugshell.py \
> -X contrib/hgweb.fcgi \ > -X contrib/hgweb.fcgi \
> -X contrib/python-zstandard/ \ > -X contrib/python-zstandard/ \
> -X contrib/win32/hgwebdir_wsgi.py \ > -X contrib/win32/hgwebdir_wsgi.py \
> -X doc/gendoc.py \ > -X doc/gendoc.py \
> -X doc/hgmanpage.py \ > -X doc/hgmanpage.py \
> -X i18n/posplit \ > -X i18n/posplit \
> -X mercurial/thirdparty \
> -X tests/hypothesishelpers.py \ > -X tests/hypothesishelpers.py \
> -X tests/test-commit-interactive.t \ > -X tests/test-commit-interactive.t \
> -X tests/test-contrib-check-code.t \ > -X tests/test-contrib-check-code.t \
> -X tests/test-demandimport.py \ > -X tests/test-demandimport.py \
> -X tests/test-extension.t \ > -X tests/test-extension.t \
> -X tests/test-hghave.t \ > -X tests/test-hghave.t \
> -X tests/test-hgweb-auth.py \ > -X tests/test-hgweb-auth.py \
> -X tests/test-hgweb-no-path-info.t \ > -X tests/test-hgweb-no-path-info.t \
> -X tests/test-hgweb-no-request-uri.t \ > -X tests/test-hgweb-no-request-uri.t \
> -X tests/test-hgweb-non-interactive.t \ > -X tests/test-hgweb-non-interactive.t \
> -X tests/test-hook.t \ > -X tests/test-hook.t \
> -X tests/test-import.t \ > -X tests/test-import.t \
> -X tests/test-imports-checker.t \ > -X tests/test-imports-checker.t \
> -X tests/test-lock.py \ > -X tests/test-lock.py \
> -X tests/test-verify-repo-operations.py \ > -X tests/test-verify-repo-operations.py \
> | sed 's-\\-/-g' | $PYTHON "$import_checker" - > | sed 's-\\-/-g' | $PYTHON "$import_checker" -

tests/test-check-pylint.t

#require test-repo pylint hg10 #require test-repo pylint hg10
Run pylint for known rules we care about. Run pylint for known rules we care about.
----------------------------------------- -----------------------------------------
There should be no recorded failures; fix the codebase before introducing a There should be no recorded failures; fix the codebase before introducing a
new check. new check.
Current checks: Current checks:
- W0102: no mutable default argument - W0102: no mutable default argument
$ touch $TESTTMP/fakerc $ touch $TESTTMP/fakerc
$ pylint --rcfile=$TESTTMP/fakerc --disable=all \ $ pylint --rcfile=$TESTTMP/fakerc --disable=all \
> --enable=W0102 --reports=no \ > --enable=W0102 --reports=no \
> --ignore=thirdparty \
> mercurial hgdemandimport hgext hgext3rd > mercurial hgdemandimport hgext hgext3rd
(?) (?)
------------------------------------ (?) ------------------------------------ (?)
Your code has been rated at 10.00/10 (?) Your code has been rated at 10.00/10 (?)
(?) (?)