| hg-reviewers |
This decouples users from the implementation details of the phasecache.
Also document a historic artifact about the stored phaseroots.
| No Linters Available |
| No Unit Test Coverage |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/phases.py (22 lines) | |||
| M | mercurial/repoview.py (8 lines) |
| Commit | Parents | Author | Summary | Date |
|---|---|---|---|---|
| fe7166727df7 | 91f4662b7fa7 | Joerg Sonnenberger | Jul 7 2020, 3:45 PM |
| Status | Author | Revision | |
|---|---|---|---|
| Closed | joerg.sonnenberger | ||
| Closed | joerg.sonnenberger | ||
| Closed | joerg.sonnenberger | ||
| Closed | joerg.sonnenberger | ||
| Closed | joerg.sonnenberger | ||
| Closed | joerg.sonnenberger |
| if _load: | if _load: | ||||
| # Cheap trick to allow shallow-copy without copy module | # Cheap trick to allow shallow-copy without copy module | ||||
| self.phaseroots, self.dirty = _readroots(repo, phasedefaults) | self.phaseroots, self.dirty = _readroots(repo, phasedefaults) | ||||
| self._loadedrevslen = 0 | self._loadedrevslen = 0 | ||||
| self._phasesets = None | self._phasesets = None | ||||
| self.filterunknown(repo) | self.filterunknown(repo) | ||||
| self.opener = repo.svfs | self.opener = repo.svfs | ||||
| def hasnonpublicphases(self, repo): | |||||
| """detect if there are revisions with non-public phase""" | |||||
| repo = repo.unfiltered() | |||||
| cl = repo.changelog | |||||
| if len(cl) >= self._loadedrevslen: | |||||
| self.invalidate() | |||||
| self.loadphaserevs(repo) | |||||
| return any(self.phaseroots[1:]) | |||||
| def nonpublicphaseroots(self, repo): | |||||
| """returns the roots of all non-public phases | |||||
| The roots are not minimized, so if the secret revisions are | |||||
| descendants of draft revisions, their roots will still be present. | |||||
| """ | |||||
| repo = repo.unfiltered() | |||||
| cl = repo.changelog | |||||
| if len(cl) >= self._loadedrevslen: | |||||
| self.invalidate() | |||||
| self.loadphaserevs(repo) | |||||
| return set().union(*[roots for roots in self.phaseroots[1:] if roots]) | |||||
| def getrevset(self, repo, phases, subset=None): | def getrevset(self, repo, phases, subset=None): | ||||
| """return a smartset for the given phases""" | """return a smartset for the given phases""" | ||||
| self.loadphaserevs(repo) # ensure phase's sets are loaded | self.loadphaserevs(repo) # ensure phase's sets are loaded | ||||
| phases = set(phases) | phases = set(phases) | ||||
| publicphase = public in phases | publicphase = public in phases | ||||
| if publicphase: | if publicphase: | ||||
| # In this case, phases keeps all the *other* phases. | # In this case, phases keeps all the *other* phases. | ||||
| return frozenset(hiddens | secrets) | return frozenset(hiddens | secrets) | ||||
| else: | else: | ||||
| return hiddens | return hiddens | ||||
| def computemutable(repo, visibilityexceptions=None): | def computemutable(repo, visibilityexceptions=None): | ||||
| assert not repo.changelog.filteredrevs | assert not repo.changelog.filteredrevs | ||||
| # fast check to avoid revset call on huge repo | # fast check to avoid revset call on huge repo | ||||
| if any(repo._phasecache.phaseroots[1:]): | if repo._phasecache.hasnonpublicphases(repo): | ||||
| getphase = repo._phasecache.phase | getphase = repo._phasecache.phase | ||||
| maymutable = filterrevs(repo, b'base') | maymutable = filterrevs(repo, b'base') | ||||
| return frozenset(r for r in maymutable if getphase(repo, r)) | return frozenset(r for r in maymutable if getphase(repo, r)) | ||||
| return frozenset() | return frozenset() | ||||
| def computeimpactable(repo, visibilityexceptions=None): | def computeimpactable(repo, visibilityexceptions=None): | ||||
| """Everything impactable by mutable revision | """Everything impactable by mutable revision | ||||
| The immutable filter still have some chance to get invalidated. This will | The immutable filter still have some chance to get invalidated. This will | ||||
| happen when: | happen when: | ||||
| - you garbage collect hidden changeset, | - you garbage collect hidden changeset, | ||||
| - public phase is moved backward, | - public phase is moved backward, | ||||
| - something is changed in the filtering (this could be fixed) | - something is changed in the filtering (this could be fixed) | ||||
| This filter out any mutable changeset and any public changeset that may be | This filter out any mutable changeset and any public changeset that may be | ||||
| impacted by something happening to a mutable revision. | impacted by something happening to a mutable revision. | ||||
| This is achieved by filtered everything with a revision number egal or | This is achieved by filtered everything with a revision number egal or | ||||
| higher than the first mutable changeset is filtered.""" | higher than the first mutable changeset is filtered.""" | ||||
| assert not repo.changelog.filteredrevs | assert not repo.changelog.filteredrevs | ||||
| cl = repo.changelog | cl = repo.changelog | ||||
| firstmutable = len(cl) | firstmutable = len(cl) | ||||
| for roots in repo._phasecache.phaseroots[1:]: | roots = repo._phasecache.nonpublicphaseroots(repo) | ||||
| if roots: | if roots: | ||||
| firstmutable = min(firstmutable, min(cl.rev(r) for r in roots)) | firstmutable = min(firstmutable, min(cl.rev(r) for r in roots)) | ||||
| # protect from nullrev root | # protect from nullrev root | ||||
| firstmutable = max(0, firstmutable) | firstmutable = max(0, firstmutable) | ||||
| return frozenset(pycompat.xrange(firstmutable, len(cl))) | return frozenset(pycompat.xrange(firstmutable, len(cl))) | ||||
| # function to compute filtered set | # function to compute filtered set | ||||
| # | # | ||||
| # When adding a new filter you MUST update the table at: | # When adding a new filter you MUST update the table at: | ||||