Differential D8698

phases: sparsify phaseroots and phasesets
ClosedPublic
Actions

Authored by joerg.sonnenberger on Jul 7 2020, 6:38 PM.

Details

Reviewers

durin42

Group Reviewers

hg-reviewers

Commits

rHG61e7464477ac: phases: sparsify phaseroots and phasesets

Summary

As final step of dealing with the holes in the phase numbers, make
phaseroots and phasesets both dictionaries indexed by the phase number.
Further adjust the interface of the C module by pushing the node to
revision mapping down as it is cheaper on the C side to deal with
revision numbers.

Overall, the patch series improves a no-change "hg up" for my NetBSD test
repository from 4.7s to 1.3s.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joerg.sonnenberger created this revision.Jul 7 2020, 6:38 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptJul 7 2020, 6:38 PM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

joerg.sonnenberger mentioned this in D8654: phases: make phase list dense or dictionaries.Jul 7 2020, 6:39 PM

durin42 accepted this revision.Jul 15 2020, 11:28 AM

durin42 added a subscriber: durin42.

durin42 added inline comments.

mercurial/cext/revlog.c
880–889	Possible improvement: `_dict_new_presized` could probably be used here since it looks like you know the possible dict size.

This revision is now accepted and ready to land.Jul 15 2020, 11:28 AM

joerg.sonnenberger updated this revision to Diff 21928.Jul 15 2020, 3:57 PM

joerg.sonnenberger added a commit: rHG61e7464477ac: phases: sparsify phaseroots and phasesets.Jul 16 2020, 12:51 PM

Closed by commit rHG61e7464477ac: phases: sparsify phaseroots and phasesets (authored by joerg.sonnenberger). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/cext/parsers.c (2 lines)
M			mercurial/cext/revlog.c (229 lines)
M			mercurial/phases.py (43 lines)
M			mercurial/policy.py (2 lines)
M			tests/test-parseindex.t (2 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	21795		Jul 7 2020, 6:38 PM	★	★
Diff 2	21928		Jul 15 2020, 3:57 PM	★	★
Diff 3	21937	rHG61e7464477acd83bdc6f68b7b6331ad88333e3de	Jul 7 2020, 6:36 PM	★	★

Status	Author	Revision
Closed	joerg.sonnenberger	D8670 repoview: use the phasecache directly to determine mutable revisions
Closed	joerg.sonnenberger	D8698 phases: sparsify phaseroots and phasesets
Closed	joerg.sonnenberger	D8697 phases: sparsify phase lists
Closed	joerg.sonnenberger	D8696 phases: updatephases should not skip internal phase
Closed	joerg.sonnenberger	D8695 phases: replace magic number by constant
Closed	joerg.sonnenberger	D8694 phases: provide a test and accessor for non-public phase roots