This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8707

commitctx: consider removed as touched
ClosedPublic

Authored by marmoute on Jul 8 2020, 4:37 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGc068e355cd71: commitctx: consider removed as touched
rHGd167f9fbb61d: commitctx: consider removed as touched
Summary

This achieve the same result with clearer code.

This is part of a larger refactoring/cleanup of the commitctx code to clarify
and augment the logic gathering metadata useful for copy tracing. The current
code is a tad too long and entangled to make such update easy. We start with
easy and small cleanup.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (4 lines)

Diff 22015

mercurial/localrepo.py

removed = [f for f in removed if f in m1 or f in m2] removed = [f for f in removed if f in m1 or f in m2]
drop = sorted([f for f in removed if f in m]) drop = sorted([f for f in removed if f in m])
for f in drop: for f in drop:
del m[f] del m[f]
if p2.rev() != nullrev: if p2.rev() != nullrev:
rf = metadata.get_removal_filter(ctx, (p1, p2, m1, m2)) rf = metadata.get_removal_filter(ctx, (p1, p2, m1, m2))
removed = [f for f in removed if not rf(f)] removed = [f for f in removed if not rf(f)]
touched.extend(removed)
if writechangesetcopy: if writechangesetcopy:
filesremoved = removed filesremoved = removed
files = touched + removed files = touched
md = None md = None
if not files: if not files:
# if no "files" actually changed in terms of the changelog, # if no "files" actually changed in terms of the changelog,
# try hard to detect unmodified manifest entry so that the # try hard to detect unmodified manifest entry so that the
# exact same commit can be reproduced later on convert. # exact same commit can be reproduced later on convert.
md = m1.diff(m, scmutil.matchfiles(self, ctx.files())) md = m1.diff(m, scmutil.matchfiles(self, ctx.files()))
if not files and md: if not files and md:
self.ui.debug( self.ui.debug(