This is an archive of the discontinued Mercurial Phabricator instance.

Differential D871

python3: don't byte mangle third-party packages
ClosedPublic

Authored by sid0 on Oct 1 2017, 7:11 AM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG9fb9f8440b71: python3: don't byte mangle third-party packages
Summary

Third-party packages are already expected to be dual-version clean.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sid0 created this revision.Oct 1 2017, 7:11 AM
sid0 updated this revision to Diff 2246.Oct 1 2017, 7:14 AM
durin42 accepted this revision.Oct 1 2017, 7:31 AM
This revision is now accepted and ready to land.Oct 1 2017, 7:31 AM
Closed by commit rHG9fb9f8440b71: python3: don't byte mangle third-party packages (authored by sid0). · Explain WhyOct 1 2017, 7:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/__init__.py (3 lines)

Diff 2251

mercurial/__init__.py

"""A sys.meta_path finder that uses a custom module loader.""" """A sys.meta_path finder that uses a custom module loader."""
def find_spec(self, fullname, path, target=None): def find_spec(self, fullname, path, target=None):
# Only handle Mercurial-related modules. # Only handle Mercurial-related modules.
if not fullname.startswith(('mercurial.', 'hgext.', 'hgext3rd.')): if not fullname.startswith(('mercurial.', 'hgext.', 'hgext3rd.')):
return None return None
# selectors2 is already dual-version clean, don't try and mangle it # selectors2 is already dual-version clean, don't try and mangle it
if fullname.startswith('mercurial.selectors2'): if fullname.startswith('mercurial.selectors2'):
return None return None
# third-party packages are expected to be dual-version clean
if fullname.startswith('mercurial.thirdparty'):
return None
# zstd is already dual-version clean, don't try and mangle it # zstd is already dual-version clean, don't try and mangle it
if fullname.startswith('mercurial.zstd'): if fullname.startswith('mercurial.zstd'):
return None return None
# pywatchman is already dual-version clean, don't try and mangle it # pywatchman is already dual-version clean, don't try and mangle it
if fullname.startswith('hgext.fsmonitor.pywatchman'): if fullname.startswith('hgext.fsmonitor.pywatchman'):
return None return None
# Try to find the module using other registered finders. # Try to find the module using other registered finders.