This is an archive of the discontinued Mercurial Phabricator instance.

Differential D873

releasenotes: raise error when no filename specified
AbandonedPublic

Authored by rishabhmadan96 on Oct 1 2017, 7:22 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

Earlier, not specifying filename with --rev raised a really long TypeError.
This patch just raises a small error to specify the filename.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

rishabhmadan96 created this revision.Oct 1 2017, 7:22 AM
pulkit added a subscriber: pulkit.Oct 1 2017, 7:26 AM

Can't we just output the releasenotes using ui.write() if no file name is specified. I sometimes wanted to check what releasenotes my commit will produce and I needed to mention a file.

rishabhmadan96 added a comment.Oct 1 2017, 7:36 AM
In D873#14703, @pulkit wrote:

Can't we just output the releasenotes using ui.write() if no file name is specified. I sometimes wanted to check what releasenotes my commit will produce and I needed to mention a file.

Seems to be a good idea :). Maybe we can close this one and I'll just send a new patch right away.

rishabhmadan96 abandoned this revision.Oct 1 2017, 7:39 AM

Revision Contents
Changeset List

Diff 2248

hgext/releasenotes.py

if listflag: if listflag:
return _getadmonitionlist(ui, sections) return _getadmonitionlist(ui, sections)
rev = opts.get('rev') rev = opts.get('rev')
revs = scmutil.revrange(repo, [rev or 'not public()']) revs = scmutil.revrange(repo, [rev or 'not public()'])
if opts.get('check'): if opts.get('check'):
return checkadmonitions(ui, repo, sections.names(), revs) return checkadmonitions(ui, repo, sections.names(), revs)
if opts.get('rev') and file_==None:
raise error.Abort(_('Specify release notes filename'))
incoming = parsenotesfromrevisions(repo, sections.names(), revs) incoming = parsenotesfromrevisions(repo, sections.names(), revs)
try: try:
with open(file_, 'rb') as fh: with open(file_, 'rb') as fh:
notes = parsereleasenotesfile(sections, fh.read()) notes = parsereleasenotesfile(sections, fh.read())
except IOError as e: except IOError as e:
if e.errno != errno.ENOENT: if e.errno != errno.ENOENT:

tests/test-releasenotes-formatting.t

abort: cannot use both '--list' and '--check' abort: cannot use both '--list' and '--check'
[255] [255]
Raise error when no filename is specified with --rev Raise error when no filename is specified with --rev
$ hg init relnotes-nofile $ hg init relnotes-nofile
$ cd relnotes-nofile $ cd relnotes-nofile
$ hg releasenote -r . $ hg releasenote -r .
** unknown exception encountered, please report by visiting abort: Specify release notes filename
** https://mercurial-scm.org/wiki/BugTracker [255]
** Python 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609]
** Mercurial Distributed SCM (version 4.3.3+701-c4594d38b2da+20171001)
** Extensions loaded: releasenotes
Traceback (most recent call last):
File "/tmp/hgtests.5N93rp/install/bin/hg", line 47, in <module>
dispatch.run()
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 81, in run
status = (dispatch(req) or 0) & 255
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 163, in dispatch
ret = _runcatch(req)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 303, in _runcatch
return _callcatch(ui, _runcatchfunc)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 311, in _callcatch
return scmutil.callcatch(ui, func)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/scmutil.py", line 151, in callcatch
return func()
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 293, in _runcatchfunc
return _dispatch(req)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 929, in _dispatch
cmdpats, cmdoptions)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 691, in runcommand
ret = _runcommand(ui, options, cmd, d)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 937, in _runcommand
return cmdfunc()
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 926, in <lambda>
d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/util.py", line 1180, in check
return func(*args, **kwargs)
File "/tmp/hgtests.5N93rp/install/lib/python/hgext/releasenotes.py", line 580, in releasenotes
with open(file_, 'rb') as fh:
TypeError: coercing to Unicode: need string or buffer, NoneType found
[1]