( )⚙ D8732 rebase: correctly check for empty commit in in-memory mode

This is an archive of the discontinued Mercurial Phabricator instance.

rebase: correctly check for empty commit in in-memory mode
ClosedPublic

Authored by mjacob on Jul 11 2020, 5:12 PM.

Details

Summary

The new code has a small overhead in the empty commit case, as a memctx object
is always created, but I don’t think it’s justified here to duplicate code
to optimize a relatively unlikely code path.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.