This is an archive of the discontinued Mercurial Phabricator instance.

mergestate: rename a helpless variable name to bit helpful one
ClosedPublic

Authored by pulkit on Jul 14 2020, 8:30 AM.

Details

Summary

The old variable name r makes it ~impossible to understand what does it mean.
One can only understand that after going to callers and hoping that its
documented there.

I also documented return value of the function involved while I was there.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Jul 14 2020, 8:30 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.