This is an archive of the discontinued Mercurial Phabricator instance.

Differential D877

releasenotes: display release notes when no filename is specified
ClosedPublic

Authored by rishabhmadan96 on Oct 1 2017, 8:00 AM.

Details

Reviewers
pulkit
yuja
Group Reviewers
hg-reviewers
Commits
rHG159a6f7e09a9: releasenotes: display release notes when no filename is specified
Summary

If the filename is not specified while using --rev, the notes for the specified
revs will just be displayed on screen.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rishabhmadan96 created this revision.Oct 1 2017, 8:00 AM
pulkit added a subscriber: pulkit.Oct 1 2017, 8:37 AM

Apart from the nit, the patch looks good to me.

hgext/releasenotes.py
579

nit: if file is None

pulkit accepted this revision.Oct 1 2017, 9:07 AM

Can you also update the doc as a follow-up as it says parse release notes from commit messages into an output file which is not always the case now.

This revision is now accepted and ready to land.Oct 1 2017, 9:39 AM
Closed by commit rHG159a6f7e09a9: releasenotes: display release notes when no filename is specified (authored by rishabhmadan96). · Explain WhyOct 1 2017, 9:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2289

hgext/releasenotes.py

rev = opts.get('rev') rev = opts.get('rev')
revs = scmutil.revrange(repo, [rev or 'not public()']) revs = scmutil.revrange(repo, [rev or 'not public()'])
if opts.get('check'): if opts.get('check'):
return checkadmonitions(ui, repo, sections.names(), revs) return checkadmonitions(ui, repo, sections.names(), revs)
incoming = parsenotesfromrevisions(repo, sections.names(), revs) incoming = parsenotesfromrevisions(repo, sections.names(), revs)
if file_ is None:
pulkitUnsubmitted
Not Done

nit: if file is None

pulkit: nit: `if file is None`
return ui.write(serializenotes(sections, incoming))
try: try:
with open(file_, 'rb') as fh: with open(file_, 'rb') as fh:
notes = parsereleasenotesfile(sections, fh.read()) notes = parsereleasenotesfile(sections, fh.read())
except IOError as e: except IOError as e:
if e.errno != errno.ENOENT: if e.errno != errno.ENOENT:
raise raise
notes = parsedreleasenotes() notes = parsedreleasenotes()

tests/test-releasenotes-formatting.t

$ cd relnotes-raise-error $ cd relnotes-raise-error
$ hg releasenotes -r . -l $ hg releasenotes -r . -l
abort: cannot use both '--list' and '--rev' abort: cannot use both '--list' and '--rev'
[255] [255]
$ hg releasenotes -l -c $ hg releasenotes -l -c
abort: cannot use both '--list' and '--check' abort: cannot use both '--list' and '--check'
[255] [255]
Display release notes for specified revs if no file is mentioned
$ hg init relnotes-nofile
$ cd relnotes-nofile
$ touch fix1
$ hg -q commit -A -l - << EOF
> commit 1
>
> .. fix:: Title of First Fix
>
> First paragraph of fix 1.
> EOF
$ hg releasenote -r .
Bug Fixes
=========
Title of First Fix
------------------
First paragraph of fix 1.