This is an archive of the discontinued Mercurial Phabricator instance.

Differential D877

releasenotes: display release notes when no filename is specified
ClosedPublic

Authored by rishabhmadan96 on Oct 1 2017, 8:00 AM.

Details

Reviewers
pulkit
yuja
Group Reviewers
hg-reviewers
Commits
rHG159a6f7e09a9: releasenotes: display release notes when no filename is specified
Summary

If the filename is not specified while using --rev, the notes for the specified
revs will just be displayed on screen.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

rishabhmadan96 created this revision.Oct 1 2017, 8:00 AM
pulkit added a subscriber: pulkit.Oct 1 2017, 8:37 AM

Apart from the nit, the patch looks good to me.

hgext/releasenotes.py
579

nit: if file is None

pulkit accepted this revision.Oct 1 2017, 9:07 AM

Can you also update the doc as a follow-up as it says parse release notes from commit messages into an output file which is not always the case now.

This revision is now accepted and ready to land.Oct 1 2017, 9:39 AM
Closed by commit rHG159a6f7e09a9: releasenotes: display release notes when no filename is specified (authored by rishabhmadan96). · Explain WhyOct 1 2017, 9:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2263

hgext/releasenotes.py

rev = opts.get('rev') rev = opts.get('rev')
revs = scmutil.revrange(repo, [rev or 'not public()']) revs = scmutil.revrange(repo, [rev or 'not public()'])
if opts.get('check'): if opts.get('check'):
return checkadmonitions(ui, repo, sections.names(), revs) return checkadmonitions(ui, repo, sections.names(), revs)
incoming = parsenotesfromrevisions(repo, sections.names(), revs) incoming = parsenotesfromrevisions(repo, sections.names(), revs)
if file_ is None:
pulkitUnsubmitted
Not Done

nit: if file is None

pulkit: nit: `if file is None`
return ui.write(serializenotes(sections, incoming))
try: try:
with open(file_, 'rb') as fh: with open(file_, 'rb') as fh:
notes = parsereleasenotesfile(sections, fh.read()) notes = parsereleasenotesfile(sections, fh.read())
except IOError as e: except IOError as e:
if e.errno != errno.ENOENT: if e.errno != errno.ENOENT:
raise raise
notes = parsedreleasenotes() notes = parsedreleasenotes()

tests/test-releasenotes-formatting.t

$ hg releasenotes -r . -l $ hg releasenotes -r . -l
abort: cannot use both '--list' and '--rev' abort: cannot use both '--list' and '--rev'
[255] [255]
$ hg releasenotes -l -c $ hg releasenotes -l -c
abort: cannot use both '--list' and '--check' abort: cannot use both '--list' and '--check'
[255] [255]
Raise error when no filename is specified with --rev Display release notes for specified revs if no file is mentioned
$ hg init relnotes-nofile $ hg init relnotes-nofile
$ cd relnotes-nofile $ cd relnotes-nofile
$ touch fix1
$ hg -q commit -A -l - << EOF
> commit 1
>
> .. fix:: Title of First Fix
>
> First paragraph of fix 1.
> EOF
$ hg releasenote -r . $ hg releasenote -r .
** unknown exception encountered, please report by visiting Bug Fixes
** https://mercurial-scm.org/wiki/BugTracker =========
** Python 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609]
** Mercurial Distributed SCM (version 4.3.3+701-c4594d38b2da+20171001) Title of First Fix
** Extensions loaded: releasenotes ------------------
Traceback (most recent call last):
File "/tmp/hgtests.5N93rp/install/bin/hg", line 47, in <module> First paragraph of fix 1.
dispatch.run()
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 81, in run
status = (dispatch(req) or 0) & 255
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 163, in dispatch
ret = _runcatch(req)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 303, in _runcatch
return _callcatch(ui, _runcatchfunc)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 311, in _callcatch
return scmutil.callcatch(ui, func)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/scmutil.py", line 151, in callcatch
return func()
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 293, in _runcatchfunc
return _dispatch(req)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 929, in _dispatch
cmdpats, cmdoptions)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 691, in runcommand
ret = _runcommand(ui, options, cmd, d)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 937, in _runcommand
return cmdfunc()
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 926, in <lambda>
d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/util.py", line 1180, in check
return func(*args, **kwargs)
File "/tmp/hgtests.5N93rp/install/lib/python/hgext/releasenotes.py", line 580, in releasenotes
with open(file_, 'rb') as fh:
TypeError: coercing to Unicode: need string or buffer, NoneType found
[1]