This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8782

tests: make flag parsing test more future safe
ClosedPublic

Authored by joerg.sonnenberger on Jul 21 2020, 4:14 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG15d35f2ba474: tests: make flag parsing test more future safe
Summary

The revlog format contains a number of feature flags, e.g. if general
deltas are active. When testing that unknown flags are rejected, use
bits that are not immediately following the currently used bits.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg accepted this revision.Aug 8 2020, 4:54 PM
This revision is now accepted and ready to land.Aug 8 2020, 4:54 PM
joerg.sonnenberger added a commit: rHG15d35f2ba474: tests: make flag parsing test more future safe.Aug 8 2020, 5:01 PM
Closed by commit rHG15d35f2ba474: tests: make flag parsing test more future safe (authored by joerg.sonnenberger). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-revlog-v2.t (4 lines)

Diff 22027

tests/test-revlog-v2.t

sparserevlog sparserevlog
store store
$ hg log $ hg log
Unknown flags to revlog are rejected Unknown flags to revlog are rejected
>>> with open('.hg/store/00changelog.i', 'wb') as fh: >>> with open('.hg/store/00changelog.i', 'wb') as fh:
... fh.write(b'\x00\x04\xde\xad') and None ... fh.write(b'\xff\x00\xde\xad') and None
$ hg log $ hg log
abort: unknown flags (0x04) in version 57005 revlog 00changelog.i! abort: unknown flags (0xff00) in version 57005 revlog 00changelog.i!
[255] [255]
$ cd .. $ cd ..
Writing a simple revlog v2 works Writing a simple revlog v2 works
$ hg init simple $ hg init simple
$ cd simple $ cd simple