This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8785

templater: simplify templatepaths() to avoid iterating a singleton list
ClosedPublic

Authored by martinvonz on Jul 22 2020, 1:24 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGe2ec36167151: templater: simplify templatepaths() to avoid iterating a singleton list
Summary

The function iterates over a hard-coded list of one element since
d844e220792a (templater: don't search randomly for templates - trust
util.datapath, 2014-09-28).

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/templater.py (8 lines)

Diff 22033

mercurial/templater.py

stream = util.increasingchunks( stream = util.increasingchunks(
stream, min=self._minchunk, max=self._maxchunk stream, min=self._minchunk, max=self._maxchunk
) )
return stream return stream
def templatepaths(): def templatepaths():
'''return locations used for template files.''' '''return locations used for template files.'''
pathsrel = [b'templates'] path = os.path.normpath(os.path.join(resourceutil.datapath, b'templates'))
paths = [ return [path] if os.path.isdir(path) else []
os.path.normpath(os.path.join(resourceutil.datapath, f))
for f in pathsrel
]
return [p for p in paths if os.path.isdir(p)]
def templatepath(name): def templatepath(name):
'''return location of template file. returns None if not found.''' '''return location of template file. returns None if not found.'''
for p in templatepaths(): for p in templatepaths():
f = os.path.join(p, name) f = os.path.join(p, name)
if os.path.exists(f): if os.path.exists(f):
return f return f