This is an archive of the discontinued Mercurial Phabricator instance.

Differential D87

infinitepush: add backup files to vfs warning bypass
ClosedPublic

Authored by durham on Jul 14 2017, 6:00 PM.
Tags
None
Subscribers
None

Details

Reviewers
quark
Group Reviewers
Restricted Project
Commits
rFBHGX43f6a8e97e8d: infinitepush: add backup files to vfs warning bypass
Summary

Upstream has added devel warnings when writing store files outside of a lock.
Certain files allow this though and there's a whitelist of which files are
allowed. Since backups happen behind the scenes and use their own lock, it's
safe to add our files to that list.

Test Plan

Ran the tests against latest upstream hg. They now pass.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Branch
treeonly (bookmark) on default (branch)
Lint
Lint OK
Unit
Unit Test Errors

Event Timeline

durham created this revision.Jul 14 2017, 6:00 PM
quark accepted this revision.Jul 14 2017, 6:04 PM
This revision is now accepted and ready to land.Jul 14 2017, 6:04 PM
Closed by commit rFBHGX43f6a8e97e8d: infinitepush: add backup files to vfs warning bypass (authored by durham). · Explain WhyJul 14 2017, 6:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Minfinitepush/__init__.py (7 lines)

Diff 164

infinitepush/__init__.py

import time import time
from .bundleparts import ( from .bundleparts import (
getscratchbranchpart, getscratchbranchpart,
scratchbookmarksparttype, scratchbookmarksparttype,
scratchbranchparttype, scratchbranchparttype,
) )
from . import ( from . import (
backupcommands,
infinitepushcommands, infinitepushcommands,
common, common,
) )
from collections import defaultdict from collections import defaultdict
from functools import partial from functools import partial
from mercurial import ( from mercurial import (
bundle2, bundle2,
changegroup, changegroup,
# remotenames circumvents the default push implementation entirely, so make # remotenames circumvents the default push implementation entirely, so make
# sure we load after it so that we wrap it. # sure we load after it so that we wrap it.
order = extensions._order order = extensions._order
order.remove('infinitepush') order.remove('infinitepush')
order.append('infinitepush') order.append('infinitepush')
extensions._order = order extensions._order = order
def extsetup(ui): def extsetup(ui):
# Allow writing backup files outside the normal lock
localrepo.localrepository._wlockfreeprefix.update([
backupcommands._backupstatefile,
backupcommands._backupgenerationfile,
])
commonsetup(ui) commonsetup(ui)
if _isserver(ui): if _isserver(ui):
serverextsetup(ui) serverextsetup(ui)
else: else:
clientextsetup(ui) clientextsetup(ui)
def commonsetup(ui): def commonsetup(ui):
wireproto.commands['listkeyspatterns'] = ( wireproto.commands['listkeyspatterns'] = (