Page MenuHomePhabricator

dirstate: isolate node len dependency for the pure version
ClosedPublic

Authored by joerg.sonnenberger on Jul 24 2020, 10:29 PM.

Details

Summary

When switching to a 256bit hash function, this still needs adjustment,
but concentrates the change in one place.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit accepted this revision.Jul 25 2020, 5:29 AM
This revision is now accepted and ready to land.Jul 25 2020, 5:29 AM
Alphare added inline comments.
mercurial/dirstate.py
1670

I'm not convinced this change is valid. The heuristic is about dirstate entries which do not contain hashes, only a path and a few integers for size, mtime, state and mode.

1838

I know this was already queued (published?), but this is part of the Rust impl and should not have been touched if the idea is only to fix the pure version, as this breaks the Rust version.

mercurial/dirstate.py
1670

Hm. In that case the whole comment above it wrong.