Page MenuHomePhabricator

dirstate: revert change to Rust binding
ClosedPublic

Authored by joerg.sonnenberger on Wed, Jul 29, 7:10 PM.

Details

Summary

The Rust binding uses its own class and is not derived from the regular
implementation. As such, it didn't get _nodelen.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz requested changes to this revision.Thu, Jul 30, 12:49 AM
martinvonz added a subscriber: martinvonz.

The commit message is missing the "why" (which is fine if that's obvious, but it doesn't seem obvious to me here). It's also unclear how this is changing a Rust binding. Are you saying that fp is an object defined in Rust?

This revision now requires changes to proceed.Thu, Jul 30, 12:49 AM

@martinvonz this is inside the dirstatemap variant defined in case we use the Rust version. I agree that a small commit description is needed, otherwise this seems fine.

@joerg.sonnenberger what about the allocation heuristic, do you also have a follow-up?

joerg.sonnenberger edited the summary of this revision. (Show Details)Thu, Jul 30, 7:30 AM
This revision was not accepted when it landed; it landed in state Needs Revision.
This revision was automatically updated to reflect the committed changes.