Only 7 out of 29 callers change the underlying dict while iterating. So it's
better to yield and wrap the 7 callers with list().
Details
Details
- Reviewers
indygreg - Group Reviewers
hg-reviewers - Commits
- rHGcdc50e1929b0: mergeresult: yield from getactions() instead of buidling a list and returning
Diff Detail
Diff Detail
- Repository
- rHG Mercurial
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Yeah, I suppose mutation during iteration will make a lot of noise. So as long as we have test coverage of this code, we should be fine.