( )⚙ D8924 requirements: introduce a set of working directory specific requirements

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8924

requirements: introduce a set of working directory specific requirements
ClosedPublic

Authored by pulkit on Aug 10 2020, 11:24 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGbd56597b2254: requirements: introduce a set of working directory specific requirements
Summary

Some requirements like the SPARSE_REQUIREMENT is working directory specific and
cannot be shared. We add a set which will contain all these requirements.

This is not the best we can do, I think having a rich requirement class will be
much better but that will be out of scope for this series.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Aug 10 2020, 11:24 AM
indygreg accepted this revision.Aug 10 2020, 9:00 PM
indygreg added a subscriber: indygreg.
indygreg added inline comments.
mercurial/requirements.py
51

I'll change this to set literal syntax in flight.

This revision is now accepted and ready to land.Aug 10 2020, 9:00 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/requirements.py (5 lines)

Diff 22379

mercurial/requirements.py

SIDEDATA_REQUIREMENT = b'exp-sidedata-flag' SIDEDATA_REQUIREMENT = b'exp-sidedata-flag'
# A repository with the the copies-sidedata-changeset requirement will store # A repository with the the copies-sidedata-changeset requirement will store
# copies related information in changeset's sidedata. # copies related information in changeset's sidedata.
COPIESSDC_REQUIREMENT = b'exp-copies-sidedata-changeset' COPIESSDC_REQUIREMENT = b'exp-copies-sidedata-changeset'
# The repository use persistent nodemap for the changelog and the manifest. # The repository use persistent nodemap for the changelog and the manifest.
NODEMAP_REQUIREMENT = b'persistent-nodemap' NODEMAP_REQUIREMENT = b'persistent-nodemap'
# List of requirements which are working directory specific
# These requirements cannot be shared between repositories if they
# share the same store
WORKING_DIR_REQUIREMENTS = set([SPARSE_REQUIREMENT])
indygregUnsubmitted
Not Done

I'll change this to set literal syntax in flight.

indygreg: I'll change this to set literal syntax in flight.
No newline at end of file