This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8975

genosxversion: don't give up if we can't find a path to hg libraries
ClosedPublic

Authored by durin42 on Sep 1 2020, 10:34 AM.

Details

Reviewers
mharbison72
pulkit
Group Reviewers
hg-reviewers
Commits
rHG148d177a4f2d: genosxversion: don't give up if we can't find a path to hg libraries
Summary

This doesn't work if you have a PyOxidized hg on $PATH, but everything
is fine if you just ignore that problem.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Sep 1 2020, 10:34 AM
mharbison72 accepted this revision.Sep 1 2020, 11:39 AM
mharbison72 added a subscriber: mharbison72.

Yeah, I remember hitting this too.

I wonder if we can have hg debuginstall exit 0 if the templated thing is actually printed- when I hit this, it was something not displayed that caused it to exit 1.

pulkit accepted this revision.Sep 2 2020, 7:54 AM
This revision is now accepted and ready to land.Sep 2 2020, 7:54 AM

Revision Contents
Changeset List

PathPackages
Mcontrib/genosxversion.py (11 lines)

Diff 22516

contrib/genosxversion.py

#!/usr/bin/env python2 #!/usr/bin/env python2
from __future__ import absolute_import, print_function from __future__ import absolute_import, print_function
import argparse import argparse
import os import os
import subprocess import subprocess
import sys import sys
try:
# Always load hg libraries from the hg we can find on $PATH. # Always load hg libraries from the hg we can find on $PATH.
hglib = subprocess.check_output(['hg', 'debuginstall', '-T', '{hgmodules}']) hglib = subprocess.check_output(['hg', 'debuginstall', '-T', '{hgmodules}'])
sys.path.insert(0, os.path.dirname(hglib)) sys.path.insert(0, os.path.dirname(hglib))
except subprocess.CalledProcessError:
# We're probably running with a PyOxidized Mercurial, so just
# proceed and hope it works out okay.
pass
from mercurial import util from mercurial import util
ap = argparse.ArgumentParser() ap = argparse.ArgumentParser()
ap.add_argument( ap.add_argument(
'--paranoid', '--paranoid',
action='store_true', action='store_true',
help=( help=(