This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8992

git: restore basic functionality after b3040b6739ce
ClosedPublic

Authored by durin42 on Sep 7 2020, 5:30 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG66a10bd1b8db: git: restore basic functionality after b3040b6739ce
Summary

We don't yet have a formal interface for the changelog, but it's
mostly specified. Sadly, b3040b6739ce added a semi-private pseudo-enum
that we need to cope with, so it's probably high time that someone
(me?) attempts to define that interface to prevent future backsliding.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Sep 7 2020, 5:30 PM
pulkit accepted this revision.Sep 8 2020, 2:26 AM
This revision is now accepted and ready to land.Sep 8 2020, 2:26 AM
durin42 added a commit: rHG66a10bd1b8db: git: restore basic functionality after b3040b6739ce.Sep 8 2020, 8:07 AM
Closed by commit rHG66a10bd1b8db: git: restore basic functionality after b3040b6739ce (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/git/gitlog.py (4 lines)

Diff 22567

hgext/git/gitlog.py

p1rev, p1rev,
p2rev, p2rev,
self._log.node(idx), self._log.node(idx),
) )
# TODO: an interface for the changelog type? # TODO: an interface for the changelog type?
class changelog(baselog): class changelog(baselog):
# TODO: this appears to be an enumerated type, and should probably
# be part of the public changelog interface
_copiesstorage = b'extra'
def __contains__(self, rev): def __contains__(self, rev):
try: try:
self.node(rev) self.node(rev)
return True return True
except error.LookupError: except error.LookupError:
return False return False
def __iter__(self): def __iter__(self):