This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9004

hgdemandimport: bypass demandimport for _ast module (issue6407)
ClosedPublic

Authored by durin42 on Sep 9 2020, 2:49 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG81b4e7c866ec: hgdemandimport: bypass demandimport for _ast module (issue6407)
rHG0d7ec06c1cde: hgdemandimport: bypass demandimport for _ast module (issue6407)
Summary

This is broken on Python 3.9rc1, and while it sounds like there may be
a fix in Python, we probably also should have this workaround in place
in hg. See the bug for more details (including on bugs at redhat and
b.p.o).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Sep 9 2020, 2:49 PM
pulkit accepted this revision.Sep 10 2020, 2:01 AM
This revision is now accepted and ready to land.Sep 10 2020, 2:01 AM
marmoute added subscribers: mercurial-devel, marmoute.Sep 23 2020, 3:11 AM

Now that a fix as landed in python 3.9 should we back this out ?

Revision Contents
Changeset List

PathPackages
Mhgdemandimport/__init__.py (1 line)

Diff 22604

hgdemandimport/__init__.py

# imported by profile, itself imported by hotshot.stats, # imported by profile, itself imported by hotshot.stats,
# not available under Windows # not available under Windows
'resource', 'resource',
# this trips up many extension authors # this trips up many extension authors
'gtk', 'gtk',
# setuptools' pkg_resources.py expects "from __main__ import x" to # setuptools' pkg_resources.py expects "from __main__ import x" to
# raise ImportError if x not defined # raise ImportError if x not defined
'__main__', '__main__',
'_ast', # https://bugs.python.org/issue41631
'_ssl', # conditional imports in the stdlib, issue1964 '_ssl', # conditional imports in the stdlib, issue1964
'_sre', # issue4920 '_sre', # issue4920
'rfc822', 'rfc822',
'mimetools', 'mimetools',
'sqlalchemy.events', # has import-time side effects (issue5085) 'sqlalchemy.events', # has import-time side effects (issue5085)
# setuptools 8 expects this module to explode early when not on windows # setuptools 8 expects this module to explode early when not on windows
'distutils.msvc9compiler', 'distutils.msvc9compiler',
'__builtin__', '__builtin__',