This is an archive of the discontinued Mercurial Phabricator instance.

mergestate: initialize all properties in __init__()
ClosedPublic

Authored by martinvonz on Sep 17 2020, 4:10 PM.

Details

Summary

This is hopefully not very controverial. I found the initialization
before this patch unorthodox. It wasn't clear which properties the
object was supposed to have.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.Sep 17 2020, 4:10 PM
indygreg accepted this revision.Sep 17 2020, 10:20 PM
indygreg added a subscriber: indygreg.

This is so much cleaner.

This revision is now accepted and ready to land.Sep 17 2020, 10:20 PM
This revision was automatically updated to reflect the committed changes.