( )⚙ D9072 phases: fix performance regression with Python 2.

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9072

phases: fix performance regression with Python 2.
ClosedPublic

Authored by joerg.sonnenberger on Sep 23 2020, 8:44 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG29a259be6424: phases: fix performance regression with Python 2
rHG497271da24c9: phases: fix performance regression with Python 2
Summary

Unlike Python 3, xrange doesn't support efficient "in" and uses a linear
time scan instead. Expand the condition to handle it fast.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/phases.py (10 lines)

Diff 22784

mercurial/phases.py

return return
low = 0 low = 0
high = len(data) high = len(data)
t = (old, new) t = (old, new)
while low < high: while low < high:
mid = (low + high) // 2 mid = (low + high) // 2
revs = data[mid][0] revs = data[mid][0]
revs_low = revs[0]
revs_high = revs[-1]
if rev in revs: if rev >= revs_low and rev <= revs_high:
_sortedrange_split(data, mid, rev, t) _sortedrange_split(data, mid, rev, t)
return return
if revs[0] == rev + 1: if revs_low == rev + 1:
if mid and data[mid - 1][0][-1] == rev: if mid and data[mid - 1][0][-1] == rev:
_sortedrange_split(data, mid - 1, rev, t) _sortedrange_split(data, mid - 1, rev, t)
else: else:
_sortedrange_insert(data, mid, rev, t) _sortedrange_insert(data, mid, rev, t)
return return
if revs[-1] == rev - 1: if revs_high == rev - 1:
if mid + 1 < len(data) and data[mid + 1][0][0] == rev: if mid + 1 < len(data) and data[mid + 1][0][0] == rev:
_sortedrange_split(data, mid + 1, rev, t) _sortedrange_split(data, mid + 1, rev, t)
else: else:
_sortedrange_insert(data, mid + 1, rev, t) _sortedrange_insert(data, mid + 1, rev, t)
return return
if revs[0] > rev: if revs_low > rev:
high = mid high = mid
else: else:
low = mid + 1 low = mid + 1
if low == len(data): if low == len(data):
data.append((pycompat.xrange(rev, rev + 1), t)) data.append((pycompat.xrange(rev, rev + 1), t))
return return