This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9082

chg: make clang format happy
ClosedPublic

Authored by marmoute on Sep 24 2020, 8:23 PM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Summary

The format breakage was introduced in eb443f7cbc2c.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Sep 24 2020, 8:23 PM
martinvonz accepted this revision.Sep 25 2020, 12:30 AM
martinvonz added a subscriber: martinvonz.

Absorbed into Valentin's patch (which was still draft and near the tip)

This revision is now accepted and ready to land.Sep 25 2020, 12:30 AM
marmoute added a comment.EditedSep 25 2020, 6:20 AM

Thanks (but apparently you did not created an obsmarker)

martinvonz added a comment.Sep 25 2020, 10:42 AM
In D9082#136320, @marmoute wrote:

Thanks (but apparently you did created an obsmarker)

What's your point? Did you want the obsmarker or not?

marmoute closed this revision.Sep 30 2020, 10:01 AM

I wanted the obsmarker. Which was not created (then my comment was wrong).

martinvonz added a comment.Sep 30 2020, 11:17 AM
In D9082#136980, @marmoute wrote:

I wanted the obsmarker. Which was not created (then my comment was wrong).

I had initially imported your patch on top of the stack. I wanted to use D7631, but that's not queued yet, so I just did it manually. I'll use hg fold next time.

Revision Contents
Changeset List

PathPackages
Mcontrib/chg/chg.c (2 lines)

Diff 22838

contrib/chg/chg.c

slash = strrchr(res, '/'); slash = strrchr(res, '/');
if (slash == NULL) if (slash == NULL)
goto cleanup; goto cleanup;
/* 4 is strlen("/hg") + nul byte */ /* 4 is strlen("/hg") + nul byte */
if (slash + 4 >= res + maxsize) if (slash + 4 >= res + maxsize)
goto cleanup; goto cleanup;
memcpy(slash, "/hg", 4); memcpy(slash, "/hg", 4);
return res; return res;
cleanup: cleanup:
free(res); free(res);
return NULL; return NULL;
} }
static const char *gethgcmd(void) static const char *gethgcmd(void)
{ {
static const char *hgcmd = NULL; static const char *hgcmd = NULL;
#ifdef HGPATHREL #ifdef HGPATHREL