This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9084

rust-dirstatemap: add #[timed] to dirstatemap read for comparison
ClosedPublic

Authored by Alphare on Sep 25 2020, 12:05 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG80bf7b1ada15: rust-dirstatemap: add #[timed] to dirstatemap read for comparison

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Sep 25 2020, 12:05 PM
martinvonz added a subscriber: martinvonz.Sep 25 2020, 1:22 PM
martinvonz added inline comments.
rust/hg-core/src/dirstate/dirstate_map.rs
18

I let hg fix move this line on step down in flight (test-check-rust-format.t was failing).

Alphare added a commit: rHG80bf7b1ada15: rust-dirstatemap: add #[timed] to dirstatemap read for comparison.Sep 25 2020, 1:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG80bf7b1ada15: rust-dirstatemap: add #[timed] to dirstatemap read for comparison (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22854

rust/hg-core/src/dirstate/dirstate_map.rs

pack_dirstate, parse_dirstate, pack_dirstate, parse_dirstate,
utils::{ utils::{
files::normalize_case, files::normalize_case,
hg_path::{HgPath, HgPathBuf}, hg_path::{HgPath, HgPathBuf},
}, },
CopyMap, DirsMultiset, DirstateEntry, DirstateError, DirstateMapError, CopyMap, DirsMultiset, DirstateEntry, DirstateError, DirstateMapError,
DirstateParents, DirstateParseError, FastHashMap, StateMap, DirstateParents, DirstateParseError, FastHashMap, StateMap,
}; };
use micro_timer::timed;
martinvonzUnsubmitted
Not Done

I let hg fix move this line on step down in flight (test-check-rust-format.t was failing).

martinvonz: I let `hg fix` move this line on step down in flight (`test-check-rust-format.t` was failing).
use core::borrow::Borrow; use core::borrow::Borrow;
use std::collections::HashSet; use std::collections::HashSet;
use std::convert::TryInto; use std::convert::TryInto;
use std::iter::FromIterator; use std::iter::FromIterator;
use std::ops::Deref; use std::ops::Deref;
use std::time::Duration; use std::time::Duration;
pub type FileFoldMap = FastHashMap<HgPathBuf, HgPathBuf>; pub type FileFoldMap = FastHashMap<HgPathBuf, HgPathBuf>;
Ok(self.parents.as_ref().unwrap()) Ok(self.parents.as_ref().unwrap())
} }
pub fn set_parents(&mut self, parents: &DirstateParents) { pub fn set_parents(&mut self, parents: &DirstateParents) {
self.parents = Some(parents.clone()); self.parents = Some(parents.clone());
self.dirty_parents = true; self.dirty_parents = true;
} }
#[timed]
pub fn read( pub fn read(
&mut self, &mut self,
file_contents: &[u8], file_contents: &[u8],
) -> Result<Option<DirstateParents>, DirstateError> { ) -> Result<Option<DirstateParents>, DirstateError> {
if file_contents.is_empty() { if file_contents.is_empty() {
return Ok(None); return Ok(None);
} }