This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9086

changing-files: move default constructor value to None
ClosedPublic

Authored by marmoute on Sep 26 2020, 8:09 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG3d5b2b8e93fd: changing-files: move default constructor value to None
Summary

According to Augie Fackler, using tuple as default value confuse PyType when
actual values are passed at init time.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Sep 26 2020, 8:09 AM
pulkit accepted this revision.Sep 28 2020, 1:51 AM
This revision is now accepted and ready to land.Sep 28 2020, 1:51 AM
marmoute added a commit: rHG3d5b2b8e93fd: changing-files: move default constructor value to None.Sep 28 2020, 8:08 AM
Closed by commit rHG3d5b2b8e93fd: changing-files: move default constructor value to None (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/metadata.py (17 lines)

Diff 22861

mercurial/metadata.py

- copied_from_p1: {"<new-name>": "<source-name-in-p1>"} mapping for copies - copied_from_p1: {"<new-name>": "<source-name-in-p1>"} mapping for copies
- copied_from_p2: {"<new-name>": "<source-name-in-p2>"} mapping for copies - copied_from_p2: {"<new-name>": "<source-name-in-p2>"} mapping for copies
See their inline help for details. See their inline help for details.
""" """
def __init__( def __init__(
self, touched=(), added=(), removed=(), p1_copies=(), p2_copies=(), self,
touched=None,
added=None,
removed=None,
p1_copies=None,
p2_copies=None,
): ):
self._added = set(added) self._added = set(() if added is None else added)
self._removed = set(removed) self._removed = set(() if removed is None else removed)
self._touched = set(touched) self._touched = set(() if touched is None else touched)
self._touched.update(self._added) self._touched.update(self._added)
self._touched.update(self._removed) self._touched.update(self._removed)
self._p1_copies = dict(p1_copies) self._p1_copies = dict(() if p1_copies is None else p1_copies)
self._p2_copies = dict(p2_copies) self._p2_copies = dict(() if p2_copies is None else p2_copies)
def __eq__(self, other): def __eq__(self, other):
return ( return (
self.added == other.added self.added == other.added
and self.removed == other.removed and self.removed == other.removed
and self.touched == other.touched and self.touched == other.touched
and self.copied_from_p1 == other.copied_from_p1 and self.copied_from_p1 == other.copied_from_p1
and self.copied_from_p2 == other.copied_from_p2 and self.copied_from_p2 == other.copied_from_p2