This is an archive of the discontinued Mercurial Phabricator instance.

rust: clippy pass
ClosedPublic

Authored by Alphare on Sep 28 2020, 8:24 AM.

Details

Summary

This removes some justified warnings and one hard error that, while technically
not a bug, was an ugly oversight on my part.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Sep 28 2020, 8:24 AM

Just to clarify, this fixes a hard error *in clippy*, not in the actual rust compiler. It just so happens that clippy is a very useful tool and I plan on maybe adding it to our CI to better catch stuff like this.

pulkit accepted this revision.Sep 30 2020, 8:51 AM
This revision is now accepted and ready to land.Sep 30 2020, 8:51 AM
marmoute accepted this revision.Sep 30 2020, 9:57 AM
Closed by commit rHG2a169781556e: rust: clippy pass (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.