This is an archive of the discontinued Mercurial Phabricator instance.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	22882		Sep 28 2020, 9:47 AM	★	★
Diff 2	22907		Sep 29 2020, 4:19 AM	★	★
Diff 3	22926	rHGa886ffd2ffc6b3fa325dbd15f8fbdcfe21fbb704	Sep 28 2020, 7:53 AM	★	★

Status	Author	Revision
Closed	acezar	D9109 rhg: use `.or(Err(Error))` not `.map_err(\|_\| Error)` (D9100#inline-15067)
Closed	acezar	D9108 hg-core: use `.or(Err(Error))` not `.map_err(\|_\| Error)` (D9100#inline-15067)
Closed	acezar	D9107 hg-core: return Err if `offset != bytes.len()`
Closed	acezar	D9106 hg-core: make `Index` owner of its bytes (D8958#inline-14994 followup 1/2)
Closed	acezar	D9105 hg-core: renaming of `Chunk` offset methods (D8958#inline-15002 followup)
Closed	acezar	D9104 hg-core: minor rewording in docstring (D8958#inline-15005 followup)
Closed	acezar	D9103 hg-core: use anonymous lifetime for `impl Chunk` (D8958#inline-15003 followup)
Closed	acezar	D9102 hg-core: use `u32` instead of `i32` in `Chunk` (D8958#inline-15001 followup)
Closed	acezar	D9101 hg-core: use the term `chunk` instead of `frag` (D8958#inline-15000 followup)
Closed	acezar	D9100 hg-core: return `Err` on decompression error (D8958#inline-15004 followup)
Closed	acezar	D9099 hg-core: remove useless code (D8958#inline-14988 followup)
Abandoned	acezar	D9098 hg-core: avoid memory allocation (D8958#inline-14990 followup)
Closed	acezar	D9097 hg-core: minor docstring update (D8958#inline-14991 followup)
Closed	acezar	D9096 hg-core: minor code style change (D8958#inline-14986 followup)
Closed	acezar	D9095 hg-core: Explain offset override of first revision
Closed	acezar	D9083 hg-core: minor code style change (D8958#inline-14993 followup)

Diff 22926

	return None;			return None;
	}			}
	let start = rev as usize * INDEX_ENTRY_SIZE;			let start = rev as usize * INDEX_ENTRY_SIZE;
	let end = start + INDEX_ENTRY_SIZE;			let end = start + INDEX_ENTRY_SIZE;
	let bytes = &self.bytes[start..end];			let bytes = &self.bytes[start..end];

	// Override the offset of the first revision as its bytes are used			// Override the offset of the first revision as its bytes are used
	// for the index's metadata (saving space because it is always 0)			// for the index's metadata (saving space because it is always 0)
	let offset_override = match rev {			let offset_override = if rev == 0 { Some(0) } else { None };
	0 => Some(0),
	_ => None,
	};

	Some(IndexEntry {			Some(IndexEntry {
	bytes,			bytes,
	offset_override,			offset_override,
	})			})
	}			}
	}			}