This is an archive of the discontinued Mercurial Phabricator instance.

hg-core: return Err if `offset != bytes.len()`
ClosedPublic

Authored by acezar on Sep 28 2020, 9:49 AM.

Details

Summary

(D8958#inline-14994 followup 2/2)

  • make Index owner of its bytes
  • make Index::new return an error if offset != bytes.len()

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

acezar created this revision.Sep 28 2020, 9:49 AM
Alphare accepted this revision.Sep 28 2020, 10:32 AM
Alphare added a subscriber: Alphare.
Alphare added inline comments.
rust/hg-core/src/revlog/revlog.rs
60–61

Is this comment still relevant?

acezar retitled this revision from hg-core: return Err if `offset != bytes.len()` (D8958#inline-14994 followup 2/2) to hg-core: return Err if `offset != bytes.len()`.Sep 29 2020, 11:53 AM
acezar edited the summary of this revision. (Show Details)
acezar updated this revision to Diff 22921.Sep 29 2020, 1:29 PM
acezar marked an inline comment as done.Sep 29 2020, 1:29 PM
acezar added inline comments.
rust/hg-core/src/revlog/revlog.rs
60–61

Not sure.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.