This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9110

updaterepo: add deprecation warning
ClosedPublic

Authored by martinvonz on Sep 28 2020, 11:55 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG00402df57db7: updaterepo: add deprecation warning
Summary

We just moved all in-tree callers off of the function, but we're
leaving it here for a bit to help extension writers.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Sep 28 2020, 11:55 AM
pulkit accepted this revision.Sep 30 2020, 8:50 AM
This revision is now accepted and ready to land.Sep 30 2020, 8:50 AM
martinvonz added a commit: rHG00402df57db7: updaterepo: add deprecation warning.Sep 30 2020, 10:17 AM
Closed by commit rHG00402df57db7: updaterepo: add deprecation warning (authored by martinvonz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hg.py (4 lines)

Diff 22951

mercurial/hg.py

def updaterepo(repo, node, overwrite, updatecheck=None): def updaterepo(repo, node, overwrite, updatecheck=None):
"""Update the working directory to node. """Update the working directory to node.
When overwrite is set, changes are clobbered, merged else When overwrite is set, changes are clobbered, merged else
returns stats (see pydoc mercurial.merge.applyupdates)""" returns stats (see pydoc mercurial.merge.applyupdates)"""
repo.ui.deprecwarn(
b'prefer merge.update() or merge.clean_update() over hg.updaterepo()',
b'5.7',
)
return mergemod._update( return mergemod._update(
repo, repo,
node, node,
branchmerge=False, branchmerge=False,
force=overwrite, force=overwrite,
labels=[b'working copy', b'destination'], labels=[b'working copy', b'destination'],
updatecheck=updatecheck, updatecheck=updatecheck,
) )