This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9170

tests: only diff the `Cargo.lock` in `test-check-cargo-lock.t`
ClosedPublic

Authored by Alphare on Oct 8 2020, 4:08 AM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHGba0d93a5f06f: tests: only diff the `Cargo.lock` in `test-check-cargo-lock.t`
Summary

While not perfect (you could be running tests while developing with a justified
modification to Cargo.lock), that use-case is small enough that I don't think
it's really going to be an issue.

This stops the test from failing for unrelated changes when running it locally.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Oct 8 2020, 4:08 AM
Alphare added a subscriber: martinvonz.Oct 8 2020, 4:47 AM

@martinvonz here's the fix you asked

martinvonz accepted this revision.Oct 8 2020, 10:55 AM
In D9170#137725, @Alphare wrote:

@martinvonz here's the fix you asked

Thanks!

This revision is now accepted and ready to land.Oct 8 2020, 10:55 AM

Revision Contents
Changeset List

PathPackages
Mtests/test-check-cargo-lock.t (2 lines)

Diff 23079

tests/test-check-cargo-lock.t

#require cargo test-repo #require cargo test-repo
$ . "$TESTDIR/helpers-testrepo.sh" $ . "$TESTDIR/helpers-testrepo.sh"
$ cd "$TESTDIR"/../rust $ cd "$TESTDIR"/../rust
Check if Cargo.lock is up-to-date. Will fail with a 101 error code if not. Check if Cargo.lock is up-to-date. Will fail with a 101 error code if not.
$ cargo check --locked --all --quiet $ cargo check --locked --all --quiet
However most CIs will run `cargo build` or similar before running the tests, so we need to check if it was modified However most CIs will run `cargo build` or similar before running the tests, so we need to check if it was modified
$ testrepohg diff $ testrepohg diff Cargo.lock