| hg-reviewers |
Earlier extras() can only be used for getting extra for a file. However at
couple of places in code, we wanted to iterate over all the extras stored with
the mergestate and they were accessing the private _stateextras.
Now, if filename is not passed, we return all the extras.
| No Linters Available |
| No Unit Test Coverage |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/commit.py (2 lines) | |||
| M | mercurial/debugcommands.py (2 lines) | |||
| M | mercurial/mergestate.py (7 lines) |
| Commit | Parents | Author | Summary | Date |
|---|---|---|---|---|
| ca34efec098e | 64a9423450ef | Pulkit Goyal | Oct 10 2020, 3:13 AM |
| copy_sd = ctx.repo().filecopiesmode == b'changeset-sidedata' | copy_sd = ctx.repo().filecopiesmode == b'changeset-sidedata' | ||||
| if copy_sd and len(ctx.parents()) > 1: | if copy_sd and len(ctx.parents()) > 1: | ||||
| # XXX this `mergestate.read` could be duplicated with a the merge state | # XXX this `mergestate.read` could be duplicated with a the merge state | ||||
| # reading in _process_files So we could refactor further to reuse it in | # reading in _process_files So we could refactor further to reuse it in | ||||
| # some cases. | # some cases. | ||||
| ms = mergestate.mergestate.read(repo) | ms = mergestate.mergestate.read(repo) | ||||
| if ms.active(): | if ms.active(): | ||||
| for fname in sorted(ms._stateextras.keys()): | for fname in sorted(ms.extras().keys()): | ||||
| might_removed = ms.extras(fname).get(b'merge-removal-candidate') | might_removed = ms.extras(fname).get(b'merge-removal-candidate') | ||||
| if might_removed == b'yes': | if might_removed == b'yes': | ||||
| if fname in ctx: | if fname in ctx: | ||||
| files.mark_salvaged(fname) | files.mark_salvaged(fname) | ||||
| return mn, files | return mn, files | ||||
| fm_extras.startitem() | fm_extras.startitem() | ||||
| fm_extras.data(key=k) | fm_extras.data(key=k) | ||||
| fm_extras.data(value=v) | fm_extras.data(value=v) | ||||
| fm_extras.end() | fm_extras.end() | ||||
| fm_files.end() | fm_files.end() | ||||
| fm_extras = fm.nested(b'extras') | fm_extras = fm.nested(b'extras') | ||||
| for f, d in sorted(pycompat.iteritems(ms._stateextras)): | for f, d in sorted(pycompat.iteritems(ms.extras())): | ||||
| if f in ms: | if f in ms: | ||||
| # If file is in mergestate, we have already processed it's extras | # If file is in mergestate, we have already processed it's extras | ||||
| continue | continue | ||||
| for k, v in pycompat.iteritems(d): | for k, v in pycompat.iteritems(d): | ||||
| fm_extras.startitem() | fm_extras.startitem() | ||||
| fm_extras.data(file=f) | fm_extras.data(file=f) | ||||
| fm_extras.data(key=k) | fm_extras.data(key=k) | ||||
| fm_extras.data(value=v) | fm_extras.data(value=v) | ||||
| for f, entry in pycompat.iteritems(self._state): | for f, entry in pycompat.iteritems(self._state): | ||||
| if entry[0] in ( | if entry[0] in ( | ||||
| MERGE_RECORD_UNRESOLVED, | MERGE_RECORD_UNRESOLVED, | ||||
| MERGE_RECORD_UNRESOLVED_PATH, | MERGE_RECORD_UNRESOLVED_PATH, | ||||
| ): | ): | ||||
| yield f | yield f | ||||
| def extras(self, filename): | def extras(self, filename=None): | ||||
| """ return extras stored with the mergestate | |||||
| if filename is passed, extras for that file is only returned """ | |||||
| if filename is None: | |||||
| return self._stateextras | |||||
| return self._stateextras[filename] | return self._stateextras[filename] | ||||
| def _resolve(self, preresolve, dfile, wctx): | def _resolve(self, preresolve, dfile, wctx): | ||||
| """rerun merge process for file path `dfile`. | """rerun merge process for file path `dfile`. | ||||
| Returns whether the merge was completed and the return value of merge | Returns whether the merge was completed and the return value of merge | ||||
| obtained from filemerge._filemerge(). | obtained from filemerge._filemerge(). | ||||
| """ | """ | ||||
| if self[dfile] in ( | if self[dfile] in ( | ||||