This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	marmoute	D9203 dirstate-tree: simplify the control flow in the Node.insert method
Closed	marmoute	D9202 dirstate-tree: move a conditional in an explicit boolean
Closed	marmoute	D9201 rust: cleanup some white space in a dock

Diff 23197

	&mut self,			&mut self,
	path: &[u8],			path: &[u8],
	new_entry: DirstateEntry,			new_entry: DirstateEntry,
	) -> InsertResult {			) -> InsertResult {
	let mut split = path.splitn(2, \|&c\| c == b'/');			let mut split = path.splitn(2, \|&c\| c == b'/');
	let head = split.next().unwrap_or(b"");			let head = split.next().unwrap_or(b"");
	let tail = split.next().unwrap_or(b"");			let tail = split.next().unwrap_or(b"");

				// Are we're modifying the current file ? Is the the end of the path ?
				let is_current_file = tail.is_empty() && head.is_empty();

	if let NodeKind::File(file) = &mut self.kind {			if let NodeKind::File(file) = &mut self.kind {
	if tail.is_empty() && head.is_empty() {			if is_current_file {
	// We're modifying the current file
	let new = Self {			let new = Self {
	kind: NodeKind::File(File {			kind: NodeKind::File(File {
	entry: new_entry,			entry: new_entry,
	..file.clone()			..file.clone()
	}),			}),
	};			};
	return InsertResult {			return InsertResult {
	did_insert: false,			did_insert: false,