This is an archive of the discontinued Mercurial Phabricator instance.

	Status	Author	Revision
	Closed	mharbison72	D9206 posix: avoid a leaked file descriptor in a unix domain socket exception case
	Closed	mharbison72	D9205 posix: use context managers in a couple of places

Diff 23204



	def setflags(f, l, x):			def setflags(f, l, x):
	st = os.lstat(f)			st = os.lstat(f)
	s = st.st_mode			s = st.st_mode
	if l:			if l:
	if not stat.S_ISLNK(s):			if not stat.S_ISLNK(s):
	# switch file to link			# switch file to link
	fp = open(f, b'rb')			with open(f, b'rb') as fp:
	data = fp.read()			data = fp.read()
	fp.close()
	unlink(f)			unlink(f)
	try:			try:
	os.symlink(data, f)			os.symlink(data, f)
	except OSError:			except OSError:
	# failed to make a link, rewrite file			# failed to make a link, rewrite file
	fp = open(f, b"wb")			with open(f, b"wb") as fp:
	fp.write(data)			fp.write(data)
	fp.close()
	# no chmod needed at this point			# no chmod needed at this point
	return			return
	if stat.S_ISLNK(s):			if stat.S_ISLNK(s):
	# switch link to file			# switch link to file
	data = os.readlink(f)			data = os.readlink(f)
	unlink(f)			unlink(f)
	fp = open(f, b"wb")			with open(f, b"wb") as fp:
	fp.write(data)			fp.write(data)
	fp.close()
	s = 0o666 & ~umask # avoid restatting for chmod			s = 0o666 & ~umask # avoid restatting for chmod

	sx = s & 0o100			sx = s & 0o100
	if st.st_nlink > 1 and bool(x) != bool(sx):			if st.st_nlink > 1 and bool(x) != bool(sx):
	# the file is a hardlink, break it			# the file is a hardlink, break it
	with open(f, b"rb") as fp:			with open(f, b"rb") as fp:
	data = fp.read()			data = fp.read()
	unlink(f)			unlink(f)