This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9211

pycompat: add an entry for unnamedtmpfile
ClosedPublic

Authored by marmoute on Oct 14 2020, 7:34 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGd4c4391aa7f2: pycompat: add an entry for unnamedtmpfile
Summary

I am going to use unnamed temporary files to pass arbitrarily large input data
to worker creating bundles. To do so, I need a unified API that work on py2 and
py3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

Diff 23221

mercurial/pycompat.py

return tempfile.mkdtemp(suffix, prefix, dir) return tempfile.mkdtemp(suffix, prefix, dir)
# text=True is not supported; use util.from/tonativeeol() instead # text=True is not supported; use util.from/tonativeeol() instead
def mkstemp(suffix=b'', prefix=b'tmp', dir=None): def mkstemp(suffix=b'', prefix=b'tmp', dir=None):
return tempfile.mkstemp(suffix, prefix, dir) return tempfile.mkstemp(suffix, prefix, dir)
# TemporaryFile does not support an "encoding=" argument on python2.
# This wrapper file are always open in byte mode.
def unnamedtempfile(mode=None, *args, **kwargs):
if mode is None:
mode = b'w+b'
else:
mode = sysstr(mode)
assert 'b' in mode
return tempfile.TemporaryFile(mode, *args, **kwargs)
# NamedTemporaryFile does not support an "encoding=" argument on python2. # NamedTemporaryFile does not support an "encoding=" argument on python2.
# This wrapper file are always open in byte mode. # This wrapper file are always open in byte mode.
def namedtempfile( def namedtempfile(
mode=b'w+b', bufsize=-1, suffix=b'', prefix=b'tmp', dir=None, delete=True mode=b'w+b', bufsize=-1, suffix=b'', prefix=b'tmp', dir=None, delete=True
): ):
mode = sysstr(mode) mode = sysstr(mode)
assert 'b' in mode assert 'b' in mode
return tempfile.NamedTemporaryFile( return tempfile.NamedTemporaryFile(
mode, bufsize, suffix=suffix, prefix=prefix, dir=dir, delete=delete mode, bufsize, suffix=suffix, prefix=prefix, dir=dir, delete=delete
) )