This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9215

transaction: use ProgrammingError for when an committed transaction is used
ClosedPublic

Authored by martinvonz on Oct 16 2020, 2:01 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG5df1655edf42: transaction: use ProgrammingError for when an committed transaction is used
Summary

It seems to me that ProgrammingError is the right type of error here.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/transaction.py (6 lines)

Diff 23248

mercurial/transaction.py

GEN_GROUP_ALL = b'all' GEN_GROUP_ALL = b'all'
GEN_GROUP_PRE_FINALIZE = b'prefinalize' GEN_GROUP_PRE_FINALIZE = b'prefinalize'
GEN_GROUP_POST_FINALIZE = b'postfinalize' GEN_GROUP_POST_FINALIZE = b'postfinalize'
def active(func): def active(func):
def _active(self, *args, **kwds): def _active(self, *args, **kwds):
if self._count == 0: if self._count == 0:
raise error.Abort( raise error.ProgrammingError(
_(
b'cannot use transaction when it is already committed/aborted' b'cannot use transaction when it is already committed/aborted'
) )
)
return func(self, *args, **kwds) return func(self, *args, **kwds)
return _active return _active
def _playback( def _playback(
journal, journal,
report, report,