This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9280

revlog: pass sidedata argument to flagutil.processflagswrite()
ClosedPublic

Authored by indygreg on Nov 7 2020, 8:23 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG11842aad3195: revlog: pass sidedata argument to flagutil.processflagswrite()
Summary

Bug found through pytype.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Nov 7 2020, 8:23 PM
Alphare accepted this revision.Nov 13 2020, 5:00 AM
indygreg added a commit: rHG11842aad3195: revlog: pass sidedata argument to flagutil.processflagswrite().Nov 18 2020, 6:06 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG11842aad3195: revlog: pass sidedata argument to flagutil.processflagswrite() (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (2 lines)

Diff 23548

mercurial/revlog.py

"""deprecated entry point to access flag processors""" """deprecated entry point to access flag processors"""
msg = b'_processflag(...) use the specialized variant' msg = b'_processflag(...) use the specialized variant'
util.nouideprecwarn(msg, b'5.2', stacklevel=2) util.nouideprecwarn(msg, b'5.2', stacklevel=2)
if raw: if raw:
return text, flagutil.processflagsraw(self, text, flags) return text, flagutil.processflagsraw(self, text, flags)
elif operation == b'read': elif operation == b'read':
return flagutil.processflagsread(self, text, flags) return flagutil.processflagsread(self, text, flags)
else: # write operation else: # write operation
return flagutil.processflagswrite(self, text, flags) return flagutil.processflagswrite(self, text, flags, None)
def revision(self, nodeorrev, _df=None, raw=False): def revision(self, nodeorrev, _df=None, raw=False):
"""return an uncompressed revision of a given node or revision """return an uncompressed revision of a given node or revision
number. number.
_df - an existing file handle to read from. (internal-only) _df - an existing file handle to read from. (internal-only)
raw - an optional argument specifying if the revision data is to be raw - an optional argument specifying if the revision data is to be
treated as raw data when applying flag transforms. 'raw' should be set treated as raw data when applying flag transforms. 'raw' should be set