This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9312

errors: raise more specific errors when default remote not configured
ClosedPublic

Authored by martinvonz on Nov 12 2020, 11:37 AM.

Details

Reviewers
mharbison72
Group Reviewers
hg-reviewers
Commits
rHG1bf1dcbc9950: errors: raise more specific errors when default remote not configured

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (4 lines)
Mtests/test-default-push.t (2 lines)

Diff 23523

mercurial/commands.py

``deleted``, even if it is in fact added remotely. ``deleted``, even if it is in fact added remotely.
Returns 0 if there are outgoing changes, 1 otherwise. Returns 0 if there are outgoing changes, 1 otherwise.
""" """
# hg._outgoing() needs to re-resolve the path in order to handle #branch # hg._outgoing() needs to re-resolve the path in order to handle #branch
# style URLs, so don't overwrite dest. # style URLs, so don't overwrite dest.
path = ui.paths.getpath(dest, default=(b'default-push', b'default')) path = ui.paths.getpath(dest, default=(b'default-push', b'default'))
if not path: if not path:
raise error.Abort( raise error.ConfigError(
_(b'default repository not configured!'), _(b'default repository not configured!'),
hint=_(b"see 'hg help config.paths'"), hint=_(b"see 'hg help config.paths'"),
) )
opts = pycompat.byteskwargs(opts) opts = pycompat.byteskwargs(opts)
if opts.get(b'graph'): if opts.get(b'graph'):
logcmdutil.checkunsupportedgraphflags([], opts) logcmdutil.checkunsupportedgraphflags([], opts)
o, other = hg._outgoing(ui, repo, dest, opts) o, other = hg._outgoing(ui, repo, dest, opts)
opts.setdefault(b'rev', []).append(b) opts.setdefault(b'rev', []).append(b)
else: else:
# if we try to push a deleted bookmark, translate it to null # if we try to push a deleted bookmark, translate it to null
# this lets simultaneous -r, -b options continue working # this lets simultaneous -r, -b options continue working
opts.setdefault(b'rev', []).append(b"null") opts.setdefault(b'rev', []).append(b"null")
path = ui.paths.getpath(dest, default=(b'default-push', b'default')) path = ui.paths.getpath(dest, default=(b'default-push', b'default'))
if not path: if not path:
raise error.Abort( raise error.ConfigError(
_(b'default repository not configured!'), _(b'default repository not configured!'),
hint=_(b"see 'hg help config.paths'"), hint=_(b"see 'hg help config.paths'"),
) )
dest = path.pushloc or path.loc dest = path.pushloc or path.loc
branches = (path.branch, opts.get(b'branch') or []) branches = (path.branch, opts.get(b'branch') or [])
ui.status(_(b'pushing to %s\n') % util.hidepassword(dest)) ui.status(_(b'pushing to %s\n') % util.hidepassword(dest))
revs, checkout = hg.addbranchrevs(repo, repo, branches, opts.get(b'rev')) revs, checkout = hg.addbranchrevs(repo, repo, branches, opts.get(b'rev'))
other = hg.peer(repo, opts, dest) other = hg.peer(repo, opts, dest)

tests/test-default-push.t

$ echo b >> b/a $ echo b >> b/a
$ hg --cwd b ci -mb $ hg --cwd b ci -mb
Push should provide a hint when both 'default' and 'default-push' not set: Push should provide a hint when both 'default' and 'default-push' not set:
$ cd c $ cd c
$ hg push --config paths.default= $ hg push --config paths.default=
abort: default repository not configured! abort: default repository not configured!
(see 'hg help config.paths') (see 'hg help config.paths')
[255] [30]
$ cd .. $ cd ..
Push should push to 'default' when 'default-push' not set: Push should push to 'default' when 'default-push' not set:
$ hg --cwd b push $ hg --cwd b push
pushing to $TESTTMP/a pushing to $TESTTMP/a
searching for changes searching for changes