This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9368

exthelper: update the examples to be python3 complaint
ClosedPublic

Authored by mharbison72 on Nov 22 2020, 3:08 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGbd22900e26ac: exthelper: update the examples to be python3 complaint

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Nov 22 2020, 3:08 PM
mharbison72 added a comment.Nov 22 2020, 3:11 PM

I accidentally interrupted phabsend with this series, so let me know if there are issue importing it. It looks like it's all here, and only that I don't have the URL embedded locally.

pulkit accepted this revision.Nov 26 2020, 7:45 AM
This revision is now accepted and ready to land.Nov 26 2020, 7:45 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/exthelper.py (38 lines)

Diff 23700

mercurial/exthelper.py

# As needed: # As needed:
cmdtable = eh.cmdtable cmdtable = eh.cmdtable
configtable = eh.configtable configtable = eh.configtable
filesetpredicate = eh.filesetpredicate filesetpredicate = eh.filesetpredicate
revsetpredicate = eh.revsetpredicate revsetpredicate = eh.revsetpredicate
templatekeyword = eh.templatekeyword templatekeyword = eh.templatekeyword
@eh.command('mynewcommand', @eh.command(b'mynewcommand',
[('r', 'rev', [], _('operate on these revisions'))], [(b'r', b'rev', [], _(b'operate on these revisions'))],
_('-r REV...'), _(b'-r REV...'),
helpcategory=command.CATEGORY_XXX) helpcategory=command.CATEGORY_XXX)
def newcommand(ui, repo, *revs, **opts): def newcommand(ui, repo, *revs, **opts):
# implementation goes here # implementation goes here
eh.configitem('experimental', 'foo', eh.configitem(b'experimental', b'foo',
default=False, default=False,
) )
@eh.filesetpredicate('lfs()') @eh.filesetpredicate(b'lfs()')
def filesetbabar(mctx, x): def filesetbabar(mctx, x):
return mctx.predicate(...) return mctx.predicate(...)
@eh.revsetpredicate('hidden') @eh.revsetpredicate(b'hidden')
def revsetbabar(repo, subset, x): def revsetbabar(repo, subset, x):
args = revset.getargs(x, 0, 0, 'babar accept no argument') args = revset.getargs(x, 0, 0, b'babar accept no argument')
return [r for r in subset if 'babar' in repo[r].description()] return [r for r in subset if b'babar' in repo[r].description()]
@eh.templatekeyword('babar') @eh.templatekeyword(b'babar')
def kwbabar(ctx): def kwbabar(ctx):
return 'babar' return b'babar'
""" """
def __init__(self): def __init__(self):
self._uipopulatecallables = [] self._uipopulatecallables = []
self._uicallables = [] self._uicallables = []
self._extcallables = [] self._extcallables = []
self._repocallables = [] self._repocallables = []
self._commandwrappers = [] self._commandwrappers = []
c(ui) c(ui)
def finalextsetup(self, ui): def finalextsetup(self, ui):
"""Method to be used as a the extension extsetup """Method to be used as a the extension extsetup
The following operations belong here: The following operations belong here:
- Changes depending on the status of other extensions. (if - Changes depending on the status of other extensions. (if
extensions.find('mq')) extensions.find(b'mq'))
- Add a global option to all commands - Add a global option to all commands
""" """
knownexts = {} knownexts = {}
for ext, command, wrapper, opts in self._extcommandwrappers: for ext, command, wrapper, opts in self._extcommandwrappers:
if ext not in knownexts: if ext not in knownexts:
try: try:
e = extensions.find(ext) e = extensions.find(ext)
def uisetup(self, call): def uisetup(self, call):
"""Decorated function will be executed during uisetup """Decorated function will be executed during uisetup
example:: example::
@eh.uisetup @eh.uisetup
def setupbabar(ui): def setupbabar(ui):
print 'this is uisetup!' print('this is uisetup!')
""" """
self._uicallables.append(call) self._uicallables.append(call)
return call return call
def uipopulate(self, call): def uipopulate(self, call):
"""Decorated function will be executed during uipopulate """Decorated function will be executed during uipopulate
example:: example::
@eh.uipopulate @eh.uipopulate
def setupfoo(ui): def setupfoo(ui):
print 'this is uipopulate!' print('this is uipopulate!')
""" """
self._uipopulatecallables.append(call) self._uipopulatecallables.append(call)
return call return call
def extsetup(self, call): def extsetup(self, call):
"""Decorated function will be executed during extsetup """Decorated function will be executed during extsetup
example:: example::
@eh.extsetup @eh.extsetup
def setupcelestine(ui): def setupcelestine(ui):
print 'this is extsetup!' print('this is extsetup!')
""" """
self._extcallables.append(call) self._extcallables.append(call)
return call return call
def reposetup(self, call): def reposetup(self, call):
"""Decorated function will be executed during reposetup """Decorated function will be executed during reposetup
example:: example::
@eh.reposetup @eh.reposetup
def setupzephir(ui, repo): def setupzephir(ui, repo):
print 'this is reposetup!' print('this is reposetup!')
""" """
self._repocallables.append(call) self._repocallables.append(call)
return call return call
def wrapcommand(self, command, extension=None, opts=None): def wrapcommand(self, command, extension=None, opts=None):
"""Decorated function is a command wrapper """Decorated function is a command wrapper
The name of the command must be given as the decorator argument. The name of the command must be given as the decorator argument.
The wrapping is installed during `uisetup`. The wrapping is installed during `uisetup`.
If the second option `extension` argument is provided, the wrapping If the second option `extension` argument is provided, the wrapping
will be applied in the extension commandtable. This argument must be a will be applied in the extension commandtable. This argument must be a
string that will be searched using `extension.find` if not found and string that will be searched using `extension.find` if not found and
Abort error is raised. If the wrapping applies to an extension, it is Abort error is raised. If the wrapping applies to an extension, it is
installed during `extsetup`. installed during `extsetup`.
example:: example::
@eh.wrapcommand('summary') @eh.wrapcommand(b'summary')
def wrapsummary(orig, ui, repo, *args, **kwargs): def wrapsummary(orig, ui, repo, *args, **kwargs):
ui.note('Barry!') ui.note(b'Barry!')
return orig(ui, repo, *args, **kwargs) return orig(ui, repo, *args, **kwargs)
The `opts` argument allows specifying a list of tuples for additional The `opts` argument allows specifying a list of tuples for additional
arguments for the command. See ``mercurial.fancyopts.fancyopts()`` for arguments for the command. See ``mercurial.fancyopts.fancyopts()`` for
the format of the tuple. the format of the tuple.
""" """
if opts is None: if opts is None:
"""Decorated function is a function wrapper """Decorated function is a function wrapper
This function takes two arguments, the container and the name of the This function takes two arguments, the container and the name of the
function to wrap. The wrapping is performed during `uisetup`. function to wrap. The wrapping is performed during `uisetup`.
(there is no extension support) (there is no extension support)
example:: example::
@eh.function(discovery, 'checkheads') @eh.function(discovery, b'checkheads')
def wrapfunction(orig, *args, **kwargs): def wrapfunction(orig, *args, **kwargs):
ui.note('His head smashed in and his heart cut out') ui.note(b'His head smashed in and his heart cut out')
return orig(*args, **kwargs) return orig(*args, **kwargs)
""" """
def dec(wrapper): def dec(wrapper):
self._functionwrappers.append((container, funcname, wrapper)) self._functionwrappers.append((container, funcname, wrapper))
return wrapper return wrapper
return dec return dec