This is an archive of the discontinued Mercurial Phabricator instance.

Differential D940

remotenames: add functions to read remotenames data from .hg/remotenames/
AbandonedPublic

Authored by pulkit on Oct 4 2017, 5:53 PM.

Details

Reviewers
dlax
Group Reviewers
hg-reviewers
Summary

This patch functions which can be used to read remotenames data from
.hg/remotenames/. The logic for the function which reads the remotenames file is
taken from the remotenames extension.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Oct 4 2017, 5:53 PM
dlax requested changes to this revision.Oct 5 2017, 4:07 AM
dlax added a subscriber: dlax.

Overall, the series only introduces helper functions. So it's hard to tell if the implementation is meaningful without any use of the code...

mercurial/remotenames.py
20

repo not used

49

Why only "bookmarks"? (and not "branches")

73

As in previous patch, readremotebookmarks and readremotebranches functions only differ from the file name; this could be factored out as a function parameter.

This revision now requires changes to proceed.Oct 5 2017, 4:07 AM
pulkit abandoned this revision.Oct 17 2017, 7:20 PM

Will revisit after the freeze.

pulkit abandoned this revision.Nov 29 2017, 5:04 PM

Updated the series with new differentials D1547 to D1551.

Revision Contents
Changeset List

PathPackages
Mmercurial/remotenames.py (34 lines)

Diff 3395

mercurial/remotenames.py

from . import ( from . import (
vfs as vfsmod, vfs as vfsmod,
) )
# directory name in .hg/ in which remotenames files will be present # directory name in .hg/ in which remotenames files will be present
remotenamedir = 'remotenames' remotenamedir = 'remotenames'
def readremotenamefile(repo, filename):
dlaxUnsubmitted
Not Done

repo not used

dlax: `repo` not used
"""
reads a file from .hg/remotenames/ directory and yields it's content
filename: the file to be read
yield a tuple (node, remotepath, name)
"""
vfs = vfsmod.vfs(repo.vfs.join(remotenamedir))
if not vfs.exists(filename):
return
f = vfs(filename)
for line in f:
line = line.strip()
if not line:
continue
node, remote, rname = line.split()
yield node, remote, rname
f.close()
def readremotenames(repo):
"""
read the details about the remotenames stored in .hg/remotenames/ and
yields a tuple (node, remotepath, name). It does not yields information
about whether an entry yielded is branch or bookmark. To get that
information, call the respective functions.
"""
for bmentry in readremotenamefile(repo, 'bookmarks'):
dlaxUnsubmitted
Not Done

Why only "bookmarks"? (and not "branches")

dlax: Why only "bookmarks"? (and not "branches")
yield bmentry
for branchentry in readremotenamefile(repo, 'branches'):
yield branchentry
def saveremotebookmarks(repo, remotepath, bookmarks): def saveremotebookmarks(repo, remotepath, bookmarks):
""" """
save remote bookmarks in .hg/remotenames/bookmarks. save remote bookmarks in .hg/remotenames/bookmarks.
The format of the data stored will be: The format of the data stored will be:
`node remotepath bookmarkname` `node remotepath bookmarkname`
bookmarks is a dictionary of remote bookmarks. bookmarks is a dictionary of remote bookmarks.
""" """
vfs = vfsmod.vfs(repo.vfs.join(remotenamedir)) vfs = vfsmod.vfs(repo.vfs.join(remotenamedir))
f = vfs('bookmarks', 'w', atomictemp=True) f = vfs('bookmarks', 'w', atomictemp=True)
for bookmark, node in sorted(bookmarks.iteritems()): for bookmark, node in sorted(bookmarks.iteritems()):
if node: if node:
f.write('%s %s %s\n' % (node, remotepath, bookmark)) f.write('%s %s %s\n' % (node, remotepath, bookmark))
f.close() f.close()
def saveremotebranches(repo, remotepath, branches): def saveremotebranches(repo, remotepath, branches):
""" """
save remote branches is .hg/remotenames/branches. save remote branches is .hg/remotenames/branches.
dlaxUnsubmitted
Not Done

As in previous patch, readremotebookmarks and readremotebranches functions only differ from the file name; this could be factored out as a function parameter.

dlax: As in previous patch, `readremotebookmarks` and `readremotebranches` functions only differ from…
The format of the data stored will be: The format of the data stored will be:
`node remotepath branchname` `node remotepath branchname`
branches is a dictionary of remote branches. branches is a dictionary of remote branches.
""" """
vfs = vfsmod.vfs(repo.vfs.join(remotenamedir)) vfs = vfsmod.vfs(repo.vfs.join(remotenamedir))
f = vfs('branches', 'w', atomictemp=True) f = vfs('branches', 'w', atomictemp=True)