This is an archive of the discontinued Mercurial Phabricator instance.

pyoxidizer: make sure defaultrc directory exists before trying to write to it
ClosedPublic

Authored by durin42 on Nov 25 2020, 11:08 AM.

Details

Summary

When doing some work involving one-file binaries, this line is failing
for me. It seems reasonable to just make sure the destination
directory exists before splatting the file into it.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

durin42 created this revision.Nov 25 2020, 11:08 AM
mharbison72 added inline comments.
contrib/packaging/hgpackaging/pyoxidizer.py
130

Should it use exist_ok=True? Or is this always missing?

durin42 updated this revision to Diff 23679.Nov 25 2020, 5:18 PM
durin42 marked an inline comment as done.Nov 25 2020, 5:19 PM

Good catch!

mharbison72 accepted this revision.Nov 25 2020, 7:09 PM
This revision is now accepted and ready to land.Nov 25 2020, 7:09 PM