( )⚙ D949 run-tests: set HGPLAIN=1 when bisecting

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D949

run-tests: set HGPLAIN=1 when bisecting
ClosedPublic

Authored by quark on Oct 5 2017, 12:22 AM.

Details

Reviewers
ryanmce
Group Reviewers
hg-reviewers
Commits
rHG149109c96904: run-tests: set HGPLAIN=1 when bisecting
Summary

Otherwise a customized template may break the regex matching the bisect
output.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Oct 5 2017, 12:22 AM
ryanmce requested changes to this revision.Oct 12 2017, 7:35 AM
This revision now requires changes to proceed.Oct 12 2017, 7:35 AM
quark updated this revision to Diff 2890.Oct 17 2017, 1:40 AM
Closed by commit rHG149109c96904: run-tests: set HGPLAIN=1 when bisecting (authored by quark). · Explain WhyOct 17 2017, 8:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (4 lines)

Diff 2890

tests/run-tests.py

return result return result
def _bisecttests(self, tests): def _bisecttests(self, tests):
bisectcmd = ['hg', 'bisect'] bisectcmd = ['hg', 'bisect']
bisectrepo = self._runner.options.bisect_repo bisectrepo = self._runner.options.bisect_repo
if bisectrepo: if bisectrepo:
bisectcmd.extend(['-R', os.path.abspath(bisectrepo)]) bisectcmd.extend(['-R', os.path.abspath(bisectrepo)])
def pread(args): def pread(args):
env = os.environ.copy()
env['HGPLAIN'] = '1'
p = subprocess.Popen(args, stderr=subprocess.STDOUT, p = subprocess.Popen(args, stderr=subprocess.STDOUT,
stdout=subprocess.PIPE) stdout=subprocess.PIPE, env=env)
data = p.stdout.read() data = p.stdout.read()
p.wait() p.wait()
return data return data
for test in tests: for test in tests:
pread(bisectcmd + ['--reset']), pread(bisectcmd + ['--reset']),
pread(bisectcmd + ['--bad', '.']) pread(bisectcmd + ['--bad', '.'])
pread(bisectcmd + ['--good', self._runner.options.known_good_rev]) pread(bisectcmd + ['--good', self._runner.options.known_good_rev])
# TODO: we probably need to forward more options # TODO: we probably need to forward more options