Page MenuHomePhabricator

commandserver: handle IOError related to flushing of streams
ClosedPublic

Authored by pulkit on Dec 4 2020, 5:57 AM.

Details

Summary

After dispatch, without chg we have handling of flushing of streams and
exception handling related to it. The exception handling part is important
because there can be exceptions when flushing fout or ferr.

One such case is in test-basic.t which was failing on python3+chg without this
patch as this handling was missing from chg.

Failure can be seen at
https://foss.heptapod.net/octobus/mercurial-devel/-/jobs/128399

Honestly I am not sure which one of chgserver.py or commandserver.py the
change should go in.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Dec 4 2020, 5:57 AM
pulkit planned changes to this revision.Dec 4 2020, 5:57 AM

Sent too soon.

pulkit updated this revision to Diff 24013.Dec 4 2020, 7:56 AM
mharbison72 accepted this revision.Dec 10 2020, 12:03 AM
This revision is now accepted and ready to land.Dec 10 2020, 12:03 AM