This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9518

wireprotov2: re-add tuple around `bundle2` check
ClosedPublic

Authored by Alphare on Dec 4 2020, 6:43 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGaad81032a128: wireprotov2: re-add tuple around `bundle2` check
Summary

I stumbled upon this while looking for the current (v1) capable method. It
looks like 9c2c77c73f23 accidentally removed the comma, turning the tuple into
a simple parenthesis expression.

This has not been detected since wireproto2 is not in use AFAIK.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Dec 4 2020, 6:43 AM
joerg.sonnenberger added a subscriber: joerg.sonnenberger.Dec 4 2020, 7:41 AM
joerg.sonnenberger added inline comments.
mercurial/httppeer.py
898

Shouldn't this be a simple == then?

Alphare added inline comments.Dec 4 2020, 7:58 AM
mercurial/httppeer.py
898

I believe the intent was to have multiple things here, but yes, it could also be ==.

pulkit accepted this revision.Dec 6 2020, 6:53 AM
This revision is now accepted and ready to land.Dec 6 2020, 6:53 AM
Alphare added a commit: rHGaad81032a128: wireprotov2: re-add tuple around `bundle2` check.Dec 6 2020, 7:16 AM
Closed by commit rHGaad81032a128: wireprotov2: re-add tuple around `bundle2` check (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/httppeer.py (2 lines)

Diff 24063

mercurial/httppeer.py

b'getbundle', b'getbundle',
b'known', b'known',
b'lookup', b'lookup',
b'pushkey', b'pushkey',
): ):
return True return True
# Other concepts. # Other concepts.
if name in b'bundle2': if name in (b'bundle2',):
joerg.sonnenbergerUnsubmitted
Not Done

Shouldn't this be a simple == then?

joerg.sonnenberger: Shouldn't this be a simple == then?
AlphareAuthorUnsubmitted
Done

I believe the intent was to have multiple things here, but yes, it could also be ==.

Alphare: I believe the intent was to have multiple things here, but yes, it could also be `==`.
return True return True
# Alias command-* to presence of command of that name. # Alias command-* to presence of command of that name.
if name.startswith(b'command-'): if name.startswith(b'command-'):
return name[len(b'command-') :] in self.apidescriptor[b'commands'] return name[len(b'command-') :] in self.apidescriptor[b'commands']
return False return False